Skip to content

fix: pass deadline through ExecuteQuery RetrySettings #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: pass deadline through ExecuteQuery RetrySettings #2355

merged 1 commit into from
Sep 25, 2024

Conversation

jackdingilian
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@jackdingilian jackdingilian requested review from a team as code owners September 25, 2024 15:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 25, 2024
mutianf
mutianf reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run mvn com.coveo:fmt-maven-plugin:format to fix the format? Thanks!
@jackdingilian
fix: pass deadline through ExecuteQuery RetrySettings
6207bb1 
Change-Id: I47fbb6761205c8ab34ecfa490954c56cf01b5288
@mutianf mutianf merged commit 6bc9820 into googleapis:main Sep 25, 2024
20 of 21 checks passed
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

2 participants

@jackdingilian @mutianf