feat: Support AuthorizedView in bigtable data client #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: xl 
trollyxia force-pushed the authorized_view_data branch from 0d2c752 to 3287381 Compare 
mutianf requested changes Mar 20, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/AuthorizedViewId.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/SampleRowKeys.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TableId.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TargetId.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TargetId.java Outdated Show resolved Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved
mutianf reviewed Mar 21, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/RowMutation.java Outdated Show resolved Hide resolved
mutianf reviewed Mar 22, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated Show resolved Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/CheckAndMutateIT.java Outdated Show resolved Hide resolved
mutianf approved these changes Mar 25, 2024
igorbernstein2 requested changes Mar 27, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java Outdated Show resolved Hide resolved
...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/ConditionalRowMutation.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/SampleRowKeys.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TargetId.java Outdated Show resolved Hide resolved
trollyxia force-pushed the authorized_view_data branch from 60365af to 9592a9e Compare mutianf reviewed Mar 27, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/NameUtil.java Show resolved Hide resolved
...-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/AuthorizedViewId.java Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/SampleRowKeys.java Outdated Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TableId.java Show resolved Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/TargetId.java Show resolved Hide resolved
trollyxia force-pushed the authorized_view_data branch from 9592a9e to e5562af Compare mutianf reviewed Mar 27, 2024
| } | ||
| ApiFutures.allAsList(futures).get(1, TimeUnit.MINUTES); | ||
| | ||
| ApiFuture<List<KeyOffset>> future = client.sampleRowKeysAsync(testEnvRule.env().getTableId()); |
Contributor
There was a problem hiding this comment.
this is doing sample row keys on the table instead of the authorized view?
we'll need to create a table with pre splits and some splits have authorized view rows and some don't
mutianf reviewed Mar 27, 2024
Contributor
mutianf left a comment
mutianf left a comment There was a problem hiding this comment.
- Can we also update the extractTableId logic in https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java#L109 so we can extract the table id from authorized view?
- Can we add something in the TestEnv to clean up stale authorized view if some tests end up hanging?
igorbernstein2 approved these changes Mar 27, 2024
Change-Id: I1e54cab5b384d76166183ac72105a4cbac59979b chore: Address review comments Change-Id: I1d9c8bc54d204dbe6752161291cbd4158ee1d6b5 chore: Add @deprecated annotation and reformat javadoc Change-Id: I3c4a0fcbecc124a9517e48a1fc747c7b8dade40e chore: Remove ReadRow(s)Options Change-Id: Ib35bdac2cd51f302fd919671324fb2c0d630af0e chore: Minor doc and test fix Change-Id: I3c8e1fa624ec0423433eae15059b5e59e9727c70 Chore: Address comments Change-Id: I8886e907ebb797a67b36240417c2e609b6f5857a Rename SampleRowKeys to SampleRowKeysRequest Change-Id: I8dda7ee1df31b184d04938cbc2f9f984d84138b4 Add javadoc for extractTargetId and hide scopedForAuthorizedView Change-Id: I38718ae9badf24db6edc1b62fc06e4d3222faeb8 fix extractTableId to correctly handle authorized view name Change-Id: I1e66fc1440a29d3861e3ee6464911324633cc5af
trollyxia force-pushed the authorized_view_data branch from ae28f38 to 512818e Compare mutianf reviewed Mar 27, 2024
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java Outdated Show resolved Hide resolved
Change-Id: Icc172b2b6d369ef8ce2b77a8e69c37af6e9aa3d7
mutianf approved these changes Mar 27, 2024
mutianf reviewed Mar 27, 2024
...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/SampleRowKeysRequest.java Show resolved Hide resolved
mutianf added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run Change-Id: I71762fad534fe31f4bf634ca5cb227f014393e37
mutianf added the owlbot:run gcf-owl-bot bot removed the owlbot:run mutianf added automerge gcf-owl-bot bot removed the owlbot:run 
igorbernstein2 added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
Contributor
| /gcbrun |
gcf-merge-on-green bot removed the automerge 
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This PR includes data client changes only, and should be merged after #2175.