Skip to content

Commit 3655af2

Browse files
committed
remove status from application latency
1 parent 0e91197 commit 3655af2

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

google-cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorder.java

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,22 @@ public void recordRetryCount(int attemptCount) {
125125
operationLevelNoStreaming.put(BuiltinMeasureConstants.RETRY_COUNT, attemptCount);
126126
}
127127

128-
public void recordApplicationLatency(long applicationLatency) {
129-
operationLevelWithStreaming.put(
130-
BuiltinMeasureConstants.APPLICATION_LATENCIES, applicationLatency);
128+
public void recordApplicationLatency(
129+
long applicationLatency, String tableId, String zone, String cluster) {
130+
MeasureMap measures =
131+
statsRecorder
132+
.newMeasureMap()
133+
.put(BuiltinMeasureConstants.APPLICATION_LATENCIES, applicationLatency);
134+
135+
TagContextBuilder tagCtx = newTagContextBuilder(tableId, zone, cluster);
136+
if (operationType == OperationType.ServerStreaming
137+
&& spanName.getMethodName().equals("ReadRows")) {
138+
tagCtx.putLocal(BuiltinMeasureConstants.STREAMING, TagValue.create("true"));
139+
} else {
140+
tagCtx.putLocal(BuiltinMeasureConstants.STREAMING, TagValue.create("false"));
141+
}
142+
143+
measures.record(tagCtx.build());
131144
}
132145

133146
public void recordFirstResponseLatency(long firstResponseLatency) {

google-cloud-bigtable-stats/src/test/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void testStreamingOperation() throws InterruptedException {
6767
tracer.recordOperationLatencies(operationLatency);
6868
tracer.recordRetryCount(attemptCount);
6969
tracer.recordAttemptLatency(attemptLatency);
70-
tracer.recordApplicationLatency(applicationLatency);
70+
tracer.recordApplicationLatency(applicationLatency, TABLE_ID, ZONE, CLUSTER);
7171
tracer.recordGfeLatencies(serverLatency);
7272
tracer.recordGfeMissingHeaders(connectivityErrorCount);
7373
tracer.recordFirstResponseLatency(firstResponseLatency);
@@ -261,7 +261,7 @@ public void testUnaryOperations() throws InterruptedException {
261261
tracer.recordOperationLatencies(operationLatency);
262262
tracer.recordRetryCount(attemptCount);
263263
tracer.recordAttemptLatency(attemptLatency);
264-
tracer.recordApplicationLatency(applicationLatency);
264+
tracer.recordApplicationLatency(applicationLatency, TABLE_ID, ZONE, CLUSTER);
265265
tracer.recordGfeLatencies(serverLatency);
266266
tracer.recordGfeMissingHeaders(connectivityErrorCount);
267267
tracer.recordFirstResponseLatency(firstResponseLatency);

0 commit comments

Comments
 (0)