Skip to content

fix: deserialize Source and SourceWithKeys correctly so SampleRowKeys only get called once #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2023
Merged

fix: deserialize Source and SourceWithKeys correctly so SampleRowKeys only get called once #4078

merged 4 commits into from
May 17, 2023

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented May 16, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@mutianf mutianf requested a review from a team as a code owner May 16, 2023 20:10
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. samples Issues that are directly related to samples. labels May 16, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels May 17, 2023
@mutianf mutianf changed the title fix: remove transient keyword for sampleRowKeys fix: deserialize Source and SourceWithKeys correctly so SampleRowKeys only get called once May 17, 2023
igorbernstein2
igorbernstein2 approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please add a basic test that serializes *deserializes a Source and ensures that all of the members propogated. Same for SourceWithKeys
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit de7bdac into googleapis:main May 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@release-please release-please bot mentioned this pull request May 17, 2023
Merged
@mutianf mutianf deleted the fix branch May 17, 2023 20:33
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2023
@release-please
chore(main): release 2.8.1 (#4079)
7e1e571 
🤖 I have created a release *beep* *boop* --- ## [2.8.1](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.8.0...v2.8.1) (2023-05-17) ### Bug Fixes * Deserialize Source and SourceWithKeys correctly so SampleRowKeys only get called once ([#4078](https://togithub.com/googleapis/java-bigtable-hbase/issues/4078)) ([de7bdac](https://togithub.com/googleapis/java-bigtable-hbase/commit/de7bdac2c8f9630ca61f1b536912fb9bfd9c4a5c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. samples Issues that are directly related to samples. size: m Pull request size is medium.

3 participants

@mutianf @igorbernstein2 @gericdong