deps: update google-cloud-bigtable dependencies #3934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
mutianf added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run mutianf added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run mutianf changed the title | Builder builder = settings.getDataSettings().toBuilder(); | ||
| builder | ||
| .stubSettings() | ||
| .setRefreshingChannel(false) |
There was a problem hiding this comment.
WE shouldn't need to enable it here, this is the shared client, at this point we already created the FixedChannelProvider which won't work with refreshing channel :)
igorbernstein2 approved these changes Jan 24, 2023
mutianf added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run mutianf added automerge gcf-owl-bot bot removed the owlbot:run 
gcf-merge-on-green bot removed the automerge 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bridge #3912 and disabling channel priming by default.