feat(bigquery): enable use of GEOGRAPHY query params #2158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR only includes a unit test. A quick scan didn't highlight an existing integration that tests all param types.
product-auto-label bot added size: s 
Neenu1995 added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run 
prash-mi approved these changes Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds support for binding a geography value directly as a query parameter, without the indirection of converting a string type to a geography time in the query body.
Related internal issue: b/238336732