Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Jan 29, 2019

This snippet will be included at the bottom of the client
library index page for the BigQuery Storage API. It will
also be included in the docs at cloud.google.com.

Adds a new session for nox to run the tests for samples
in the docs directory. Acts as a system test of the rows()
method.

This snippet will be included at the bottom of the client library index page for the BigQuery Storage API. It will also be included in the docs at cloud.google.com. Adds a new session for nox to run the tests for samples in the docs directory. Acts as a system test of the rows() method.
@tswast tswast added the api: bigquerystorage Issues related to the BigQuery Storage API. label Jan 29, 2019
@tswast tswast requested a review from shollyman January 29, 2019 23:35
@tswast tswast requested a review from crwilcox as a code owner January 29, 2019 23:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2019
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

installation doc nit: we talk about the pip install for getting fastavro pretty deep in the comments, and the generated doc at https://googlecloudplatform.github.io/google-cloud-python/latest/bigquery_storage/index.html makes no mention of it. Should we augment the readme/docs for the library as well to mention the additional fastavro dependency, or handle it in another fashion?

@tswast tswast merged commit fd19a75 into googleapis:master Jan 31, 2019
@tswast tswast deleted the bqstorage-python-snippet branch January 31, 2019 00:02
parthea pushed a commit that referenced this pull request Aug 21, 2025
* Add quickstart demonstrating most BQ Storage API read features This snippet will be included at the bottom of the client library index page for the BigQuery Storage API. It will also be included in the docs at cloud.google.com. Adds a new session for nox to run the tests for samples in the docs directory. Acts as a system test of the rows() method. * s/handles reconnecting/reconnects/ * Add note about optional dependencies to readme.
parthea pushed a commit that referenced this pull request Sep 16, 2025
* Add quickstart demonstrating most BQ Storage API read features This snippet will be included at the bottom of the client library index page for the BigQuery Storage API. It will also be included in the docs at cloud.google.com. Adds a new session for nox to run the tests for samples in the docs directory. Acts as a system test of the rows() method. * s/handles reconnecting/reconnects/ * Add note about optional dependencies to readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement.

3 participants