fix: auth fetch token from default endpoint #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can you push this change to gce vm which has a non-default SA attached to it and verify the change works? |
sai-sunder-s approved these changes Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fetch the token using "default" service account email. For other purposes, the call is still available for customers. As sometimes if a customer has overridden the principal to something else then this call fails. Therefore, to avoid such cases fetching the token using "default" endpoint. The reason this change works is because mds is associated with only 1 service account, so we do not need to provide an email address for fetching the token.