feat: update retries and implement Retryable #750
Conversation
google-cla bot added the cla: yes 
…r text credential source (#822) * fix: remove erroneous check for the subject token field name for text format in IdentityPoolCredentialSource * fix: case insensitive * fix: null check * fix: imports
oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java Outdated Show resolved Hide resolved
lesv left a comment
lesv left a comment There was a problem hiding this comment.
I need to spend a bit more time w/ your testing, but I'm generally favorable. If I didn't comment on Jeff's comment's, I probably agree with them. Even were I disagree, I'll defer to him if he insists.
ServiceAccountCredentials constructor has way too many parameters and should be made into a builder pattern - especially since your breaking any contract anyway.
I want to spend a bit more time thinking through your tests, but I believe you've implemented what I read in the design docs.
oauth2_http/java/com/google/auth/oauth2/GoogleAuthException.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated Show resolved Hide resolved
lesv left a comment
lesv left a comment There was a problem hiding this comment.
I'm sending this early as I'm going to get lunch.
I found some stuff that you will want to change. I'm suggesting change to the form of the builder pattern that I ok'd yesterday - apologies - I should n't type on my phone. I'm ok if you don't want to do it. I'm unattached to my suggestions on names.
I'll pick up where I left off in an hour or so.
lesv left a comment
lesv left a comment There was a problem hiding this comment.
Ignore my earlier comments. LGTM
| | ||
| package com.google.auth; | ||
| | ||
| // an interface to identify retryable errors |
There was a problem hiding this comment.
/** Retryable is an interface to identify retryable errors. */
7 participants
This is PR fixes retries to token endpoint.
For more details on the feature: go/auth-correct-retry
Fixes #626