Skip to content

Conversation

@lsirac
Copy link
Contributor

@lsirac lsirac commented Jun 4, 2025

Changed "preferrable" to "preferable" in a comment within the getRequestMetadata method.

Changed "preferrable" to "preferable" in a comment within the getRequestMetadata method.
@lsirac lsirac requested review from a team as code owners June 4, 2025 03:54
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 4, 2025
@lsirac lsirac requested a review from lqiu96 June 4, 2025 14:37
@lqiu96
Copy link
Member

lqiu96 commented Jun 4, 2025

fyi, updating the title of this to doc:

@lqiu96 lqiu96 changed the title Fix: Correct typo in ServiceAccountJwtAccessCredentials.java comment docs: Correct typo in ServiceAccountJwtAccessCredentials.java comment Jun 4, 2025
lqiu96
lqiu96 previously approved these changes Jun 4, 2025
@lqiu96 lqiu96 dismissed their stale review June 4, 2025 15:43

Testing dismiss review

@lsirac lsirac merged commit 3058b06 into googleapis:main Jun 4, 2025
26 checks passed
@lsirac lsirac deleted the fix/typo-preferable branch June 4, 2025 15:55
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jun 5, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [io.netty:netty-handler](https://netty.io/) ([source](https://github.com/netty/netty)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `4.2.1.Final` -> `4.2.2.Final` | | [io.netty:netty-bom](https://netty.io/) ([source](https://github.com/netty/netty)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `4.2.1.Final` -> `4.2.2.Final` | | [com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.36.0` -> `1.37.0` | | [com.google.auth:google-auth-library-credentials](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.36.0` -> `1.37.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.56` -> `2.31.57` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http)</summary> ### [`v1.37.0`](https://github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1370-2025-06-04) ##### Features - **mtls:** Introduce DefaultMtlsProviderFactory and SecureConnectProvider ([#&#8203;1730](googleapis/google-auth-library-java#1730)) ([c9fd1b1](googleapis/google-auth-library-java@c9fd1b1)) ##### Bug Fixes - Correct capitalization of GitHub ([#&#8203;1761](googleapis/google-auth-library-java#1761)) ([f79a2e4](googleapis/google-auth-library-java@f79a2e4)) - Correct extra spaces in README heading ([#&#8203;1760](googleapis/google-auth-library-java#1760)) ([8d26666](googleapis/google-auth-library-java@8d26666)) - Correct misspelling of OAuth in comments ([#&#8203;1762](googleapis/google-auth-library-java#1762)) ([42b9602](googleapis/google-auth-library-java@42b9602)) - Correct typo in ServiceAccountJwtAccessCredentials.java comment ([#&#8203;1765](googleapis/google-auth-library-java#1765)) ([3058b06](googleapis/google-auth-library-java@3058b06)) - Update Javadoc reference in ExternalAccountCredentials ([#&#8203;1763](googleapis/google-auth-library-java#1763)) ([5eb3659](googleapis/google-auth-library-java@5eb3659)) ##### Documentation - Duplicate "the" in Javadoc comments ([#&#8203;1764](googleapis/google-auth-library-java#1764)) ([5f7a084](googleapis/google-auth-library-java@5f7a084)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 57d30e592601468e7e82f86d4dcf27523cdba475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

2 participants