fix(sec): warn users of unsafe credential generation methods #2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lqiu96 reviewed Sep 22, 2025
...-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java Outdated Show resolved Hide resolved
lqiu96 reviewed Sep 22, 2025
...-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java Outdated Show resolved Hide resolved
lqiu96 reviewed Sep 22, 2025
...-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java Outdated Show resolved Hide resolved
lqiu96 reviewed Sep 22, 2025
| * @return the credential defined by the credentialStream. | ||
| * @throws IOException if the credential cannot be created from the stream. | ||
| * @deprecated This method is being deprecated because of a potential security risk. | ||
| * Please use {@link <a href="https://javadoc.io/doc/com.google.auth/google-auth-library-oauth2-http/latest/com/google/auth/oauth2/GoogleCredentials.html">GoogleCredentials</a> instead. |
There was a problem hiding this comment.
Can you link to cloud rad instead of javadoc?
There was a problem hiding this comment.
Will raise a separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unlike the efforts in the current non-deprecated auth library googleapis/google-auth-library-java#1802 and googleapis/google-auth-library-java#1798, this library is deprecated and promotes usage of google-auth-library-java.
However, we also add a comment with notice of the unsafety of the
fromStream()methods, repeating the existing note of class deprecation (theGoogleCredentialis already deprecated).This library does not have subclasses for credentials (e.g. service account credentials).