You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+12-9Lines changed: 12 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,6 @@ This project follows
27
27
28
28
> [!NOTE]
29
29
> New contributions should always include both unit and integration tests.
30
-
31
30
32
31
All submissions, including submissions by project members, require review. We
33
32
use GitHub pull requests for this purpose. Consult
@@ -37,14 +36,14 @@ information on using pull requests.
37
36
### Code reviews
38
37
39
38
* Within 2-5 days, a reviewer will review your PR. They may approve it, or request
40
-
changes.
39
+
changes.
41
40
* When requesting changes, reviewers should self-assign the PR to ensure
42
41
they are aware of any updates.
43
42
* If additional changes are needed, push additional commits to your PR branch -
44
-
this helps the reviewer know which parts of the PR have changed.
43
+
this helps the reviewer know which parts of the PR have changed.
45
44
* Commits will be
46
45
squashed when merged.
47
-
* Please follow up with changes promptly.
46
+
* Please follow up with changes promptly.
48
47
* If a PR is awaiting changes by the
49
48
author for more than 10 days, maintainers may mark that PR as Draft. PRs that
50
49
are inactive for more than 30 days may be closed.
@@ -53,12 +52,16 @@ are inactive for more than 30 days may be closed.
53
52
54
53
Please create an
55
54
[issue](https://github.com/googleapis/genai-toolbox/issues) before
56
-
implementation to ensure we can accept the contribution and no duplicated work. This issue
57
-
should include an overview of the API design. If you have any questions, reach out on our
58
-
[Discord](https://discord.gg/Dmm69peqjh) to chat directly with the team.
55
+
implementation to ensure we can accept the contribution and no duplicated work.
56
+
This issue should include an overview of the API design. If you have any
57
+
questions, reach out on our [Discord](https://discord.gg/Dmm69peqjh) to chat
58
+
directly with the team.
59
59
60
60
> [!NOTE]
61
-
> New tools can be added for [pre-existing data sources](https://github.com/googleapis/genai-toolbox/tree/main/internal/sources). However, any new database source should also include at least one new tool type.
The `-v` flag mounts your local `tools.yaml` into the container, and `-p` maps the container's port `5000` to your host's port `5000`.
198
+
The `-v` flag mounts your local `tools.yaml` into the container, and `-p` maps
199
+
the container's port `5000` to your host's port `5000`.
198
200
199
201
</details>
200
202
201
203
<details>
202
204
203
205
<summary>Source</summary>
204
206
205
-
To run the server directly from source, navigate to the project root directory and run:
207
+
To run the server directly from source, navigate to the project root directory
208
+
and run:
206
209
207
210
```sh
208
211
go run .
209
212
```
210
213
211
214
ⓘ **NOTE:**
212
-
This command runs the project from source, and is more suitable for development and testing. It does **not** compile a binary into your `$GOPATH`. If you want to compile a binary instead, refer the [Developer Documentation](./DEVELOPER.md#building-the-binary).
215
+
This command runs the project from source, and is more suitable for development
216
+
and testing. It does **not** compile a binary into your `$GOPATH`. If you want
If you installed Toolbox using [Homebrew](https://brew.sh/), the `toolbox` binary is available in your system path. You can start the server with the same command:
226
+
If you installed Toolbox using [Homebrew](https://brew.sh/), the `toolbox`
227
+
binary is available in your system path. You can start the server with the same
228
+
command:
221
229
222
230
```sh
223
231
toolbox --tools-file "tools.yaml"
@@ -232,7 +240,6 @@ For more detailed documentation on deploying to different environments, check
0 commit comments