This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: scope the throttling metric to exclude element size calculation #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This should prevent off by 1 failures in unit tests on slow vms
mutianf approved these changes Oct 19, 2022
| Kudos, SonarCloud Quality Gate passed! |
meltsufin approved these changes Oct 19, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 19, 2022
🤖 I have created a release *beep* *boop* --- ## [2.19.4](https://togithub.com/googleapis/gax-java/compare/v2.19.3...v2.19.4) (2022-10-19) ### Bug Fixes * Scope the throttling metric to exclude element size calculation ([#1835](https://togithub.com/googleapis/gax-java/issues/1835)) ([0287f83](https://togithub.com/googleapis/gax-java/commit/0287f83f9cabbb9dff6cb7e8ea3068ccc1ab12d9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This should prevent off by 1 failures in unit tests on slow vms