Skip to content

Commit c885150

Browse files
cushonError Prone Team
authored andcommitted
Add a regression test for b/369862572
PiperOrigin-RevId: 679372973
1 parent 2b78c1f commit c885150

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/MemberName.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ public Description matchClass(ClassTree tree, VisitorState state) {
102102
ClassSymbol symbol = getSymbol(tree);
103103
String name = tree.getSimpleName().toString();
104104
if (name.isEmpty() || isConformantUpperCamelName(name)) {
105-
// name.isEmpty() should not happen normally but could if there are errors.
105+
// The name can be empty for enum member declarations, which are desugared early to class
106+
// declarations.
106107
return NO_MATCH;
107108
}
108109
String renamed = suggestedClassRename(name);

core/src/test/java/com/google/errorprone/bugpatterns/MemberNameTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -622,4 +622,17 @@ public void className_underscore() {
622622
"}")
623623
.doTest();
624624
}
625+
626+
@Test
627+
public void enumName() {
628+
helper
629+
.addSourceLines(
630+
"Test.java", //
631+
"enum Test {",
632+
" ONE {",
633+
" void f() {}",
634+
" }",
635+
"}")
636+
.doTest();
637+
}
625638
}

0 commit comments

Comments
 (0)