Skip to content

Commit 2c04ada

Browse files
java-team-github-botError Prone Team
authored andcommitted
Support toSeconds in DurationToLongTimeUnit
PiperOrigin-RevId: 676555168
1 parent fa3c23d commit 2c04ada

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/time/DurationToLongTimeUnit.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ public final class DurationToLongTimeUnit extends BugChecker
7878
// JavaTime
7979
.put(instanceMethod().onExactClass(JAVA_DURATION).named("toNanos"), NANOSECONDS)
8080
.put(instanceMethod().onExactClass(JAVA_DURATION).named("toMillis"), MILLISECONDS)
81+
.put(instanceMethod().onExactClass(JAVA_DURATION).named("toSeconds"), SECONDS)
8182
.put(instanceMethod().onExactClass(JAVA_DURATION).named("getSeconds"), SECONDS)
8283
.put(instanceMethod().onExactClass(JAVA_DURATION).named("toMinutes"), MINUTES)
8384
.put(instanceMethod().onExactClass(JAVA_DURATION).named("toHours"), HOURS)

core/src/test/java/com/google/errorprone/bugpatterns/time/DurationToLongTimeUnitTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ void javaTime(Future<String> f, java.time.Duration d) throws Exception {
4343
f.get(42L, TimeUnit.SECONDS);
4444
f.get(d.toNanos(), TimeUnit.NANOSECONDS);
4545
f.get(d.toMillis(), TimeUnit.MILLISECONDS);
46+
f.get(d.toSeconds(), TimeUnit.SECONDS);
4647
f.get(d.getSeconds(), TimeUnit.SECONDS);
4748
f.get(d.toMinutes(), TimeUnit.MINUTES);
4849
f.get(d.toHours(), TimeUnit.HOURS);
@@ -104,6 +105,7 @@ void javaTime(Future<String> f, java.time.Duration d) throws Exception {
104105
f.get(42L, SECONDS);
105106
f.get(d.toNanos(), NANOSECONDS);
106107
f.get(d.toMillis(), MILLISECONDS);
108+
f.get(d.toSeconds(), SECONDS);
107109
f.get(d.getSeconds(), SECONDS);
108110
f.get(d.toMinutes(), MINUTES);
109111
f.get(d.toHours(), HOURS);
@@ -161,6 +163,8 @@ void javaTime(Future<String> f, java.time.Duration d) throws Exception {
161163
f.get(d.toNanos(), TimeUnit.MILLISECONDS);
162164
// BUG: Diagnostic contains: f.get(d.toMillis(), TimeUnit.MILLISECONDS)
163165
f.get(d.toMillis(), TimeUnit.NANOSECONDS);
166+
// BUG: Diagnostic contains: f.get(d.toSeconds(), TimeUnit.SECONDS)
167+
f.get(d.toSeconds(), TimeUnit.MINUTES);
164168
// BUG: Diagnostic contains: f.get(d.getSeconds(), TimeUnit.SECONDS)
165169
f.get(d.getSeconds(), TimeUnit.MINUTES);
166170
// BUG: Diagnostic contains: f.get(d.toMinutes(), TimeUnit.MINUTES)
@@ -233,6 +237,8 @@ void javaTime(Future<String> f, java.time.Duration d) throws Exception {
233237
f.get(d.toNanos(), MILLISECONDS);
234238
// BUG: Diagnostic contains: f.get(d.toMillis(), TimeUnit.MILLISECONDS)
235239
f.get(d.toMillis(), NANOSECONDS);
240+
// BUG: Diagnostic contains: f.get(d.toSeconds(), TimeUnit.SECONDS)
241+
f.get(d.toSeconds(), MINUTES);
236242
// BUG: Diagnostic contains: f.get(d.getSeconds(), TimeUnit.SECONDS)
237243
f.get(d.getSeconds(), MINUTES);
238244
// BUG: Diagnostic contains: f.get(d.toMinutes(), TimeUnit.MINUTES)

0 commit comments

Comments
 (0)