Add tests for subtypes of Immutable and ThreadSafe classes

PiperOrigin-RevId: 821572897

Author: cushon

core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java

@@ -4213,4 +4213,35 @@ record R(ImmutableList<String> xs) {}
  """)
  .doTest();
  }
+
+ @Test
+ public void subtyping() {
+ compilationHelper
+ .addSourceLines(
+ "Test.java",
+ """
+ import com.google.errorprone.annotations.Immutable;
+
+ @Immutable
+ interface ImmutableInterface {}
+
+ @Immutable
+ abstract class ImmutableAbstractClass {}
+
+ class B implements ImmutableInterface {}
+
+ class D extends ImmutableAbstractClass {}
+
+ class F implements ImmutableInterface {
+ // BUG: Diagnostic contains: has non-final field
+ Object unsafe;
+ }
+
+ class H extends ImmutableAbstractClass {
+ // BUG: Diagnostic contains: has non-final field
+ Object unsafe;
+ }
+ """)
+ .doTest();
+ }
 }

core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ThreadSafeCheckerTest.java

@@ -1602,4 +1602,38 @@ class Test {
  """)
  .doTest();
  }
+
+ @Test
+ public void subtyping() {
+ compilationHelper
+ .addSourceLines(
+ "Test.java",
+ """
+ package a;
+
+ import com.google.errorprone.annotations.ThreadSafe;
+
+ @ThreadSafe
+ interface ThreadSafeInterface {}
+
+ @ThreadSafe
+ abstract class ThreadSafeAbstractClass {}
+
+ // BUG: Diagnostic contains: is not annotated
+ class A implements ThreadSafeInterface {}
+
+ class C extends ThreadSafeAbstractClass {}
+
+ // BUG: Diagnostic contains: is not annotated
+ class E implements ThreadSafeInterface {
+ Object unsafe;
+ }
+
+ class G extends ThreadSafeAbstractClass {
+ // BUG: Diagnostic contains: fields should be final or annotated with @GuardedBy
+ Object unsafe;
+ }
+ """)
+ .doTest();
+ }
 }