Skip to content

Output URL not working, if output has URL before the environment URL #34

@Hi-Fi

Description

@Hi-Fi

TL;DR

Currently Gcloud SDK output contains following:

For the latest full release notes, please visit:
https://cloud.google.com/sdk/release_notes

This causes outputs.url to be set to https://cloud.google.com

Expected behavior

Parsing should find environment's correct URL from the output

Observed behavior

Code (https://github.com/google-github-actions/deploy-appengine/blob/main/src/main.ts#L117-L119) takes first URL in the output, which just points to sdk release notes (and takes only host part from there)

Reproduction

Action YAML

 runs-on: ubuntu-latest environment: name: PR url: ${{ steps.deploy_review.outputs.url }} steps: - name: Checkout uses: actions/checkout@v2 - name: Deploy review id: deploy_review uses: google-github-actions/deploy-appengine@32c708ac578033217aed2f2822d5ddd60999612e #0.3.0 with: credentials: ${{ secrets.GCP_SA_KEY }} working_directory: ./core version: pr-${{ github.event.pull_request.number }} promote: false

Repository

https://github.com/Hi-Fi/sss/blob/feat/environment_to_pipeline/.github/workflows/core.yml

Additional information

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions