Bug#38439895 Warnings when compiling server in release mode (NDB)

Refactor computeHash function including removing false warning on OEL8 with GCC 14.2.1. storage/ndb/src/ndbapi/Ndb.cpp: In static member function 'static int Ndb::computeHash(Uint32*, const NdbDictionary::Table*, const Key_part_ptr*, void*, Uint32)': storage/ndb/src/ndbapi/Ndb.cpp:489:11: warning: 'buf' may be used uninitialized [-Wmaybe-uninitialized] 489 | md5_hash(values, (const char *)buf, len); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I39b1b1bdc70ce7487e07d95b7eecb2be963481b1

Author: zmur

storage/ndb/src/ndbapi/Ndb.cpp

@@ -437,18 +437,11 @@ int Ndb::computeHash(Uint32 *retval, const NdbDictionary::Table *table,
  sumlen += len;
  }
 
- while (true) {
- if (buf == nullptr) {
- bufLen = sumlen;
- buf = malloc(bufLen);
- if (unlikely(buf == nullptr)) return 4000;
- malloced_buf = buf; /* Remember to free */
- }
- assert(bufLen != 0);
-
- if (likely(sumlen <= bufLen)) break;
- require(malloced_buf == nullptr);
- buf = nullptr;
+ if (unlikely(buf == nullptr || sumlen > bufLen)) {
+ bufLen = sumlen;
+ buf = malloc(bufLen);
+ if (unlikely(buf == nullptr)) return 4000;
+ malloced_buf = buf; /* Remember to free */
  }
 
  pos = (unsigned char *)buf;
@@ -486,6 +479,8 @@ int Ndb::computeHash(Uint32 *retval, const NdbDictionary::Table *table,
  require(len <= bufLen);
 
  Uint32 values[4];
+ // Avoid maybe-uninitialized warning for md5_hash call
+ if (unlikely(len == 0)) buf = nullptr;
  md5_hash(values, (const char *)buf, len);
 
  if (retval) {