cmd/compile,runtime: go tip breaks github.com/ethereum/go-ethereum/rlp #32595
Description
What version of Go are you using (go version)?
$ go version go version devel +b388d6868f Thu Jun 13 03:58:18 2019 +0000 linux/amd64
Does this issue reproduce with the latest release?
No.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env GO111MODULE="off" GOARCH="amd64" GOBIN="" GOCACHE="/home/cuonglm/.cache/go-build" GOENV="/home/cuonglm/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/cuonglm/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/cuonglm/sources/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/cuonglm/sources/go/pkg/tool/linux_amd64" GCCGO="/usr/local/bin/gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build174470444=/tmp/go-build -gno-record-gcc-switches"
What did you do?
$ cd $GOPATH/src/github.com/ethereum/go-ethereum/rlp $ go test -count=1 What did you expect to see?
Test passed.
What did you see instead?
--- FAIL: TestDecodeWithByteReader (0.00s) decode_test.go:582: test 40: value mismatch got [0]uint8{} want [0]uint8{} decoding into *[0]uint8 input "80" --- FAIL: TestDecodeWithNonByteReader (0.00s) decode_test.go:582: test 40: value mismatch got [0]uint8{} want [0]uint8{} decoding into *[0]uint8 input "80" --- FAIL: TestDecodeStreamReset (0.00s) decode_test.go:582: test 40: value mismatch got [0]uint8{} want [0]uint8{} decoding into *[0]uint8 input "80" FAIL exit status 1 FAIL github.com/ethereum/go-ethereum/rlp 0.005s The test still works with go 1.12.6 and earlier.
I can't produce with minimal example, but cherry pick point to fff4f59
cc @randall77