Skip to content

internal/gocore: handle unsafe.pointer case for sync.entry.p in sync.map #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

internal/gocore: handle unsafe.pointer case for sync.entry.p in sync.map #12

wants to merge 3 commits into from

Conversation

@doujiang24
Copy link
Contributor

@doujiang24 doujiang24 commented Jul 24, 2022

No description provided.

@gopherbot
Copy link
Contributor

gopherbot commented Jul 24, 2022

This PR (HEAD: 2523ab2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2022

This PR (HEAD: b7ca5f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jul 29, 2022

Message from Keith Randall:

Patch Set 2: Run-TryBot+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

This PR (HEAD: 9448ffb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/debug/+/419177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jul 30, 2022

Message from DeJiang Zhu:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 3: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Michael Pratt:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 1, 2022

Message from Keith Randall:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
@doujiang24 doujiang24 changed the title gcore: handle the special unsafe.pointer case for sync.entry.p in sync.map. internal/gocore: handle unsafe.pointer case for sync.entry.p in sync.map Aug 2, 2022
@gopherbot
Copy link
Contributor

gopherbot commented Aug 2, 2022

Message from DeJiang Zhu:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/419177.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request Aug 4, 2022
@doujiang24 @hyangah
internal/gocore: handle unsafe.pointer case for sync.entry.p in sync.map
8ea6c74 
Change-Id: I8c75440d8557d48cff039d228ba8a87f0fd215f2 GitHub-Last-Rev: 9448ffb GitHub-Pull-Request: #12 Reviewed-on: https://go-review.googlesource.com/c/debug/+/419177 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Aug 4, 2022

This PR is being closed because golang.org/cl/419177 has been merged.
@gopherbot gopherbot closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@doujiang24 @gopherbot