Skip to content

Commit b14df6e

Browse files
authored
Merge pull request #1868 from dsnopek/meta-required
Specifically handle each "meta" value, so new ones don't break code generation
2 parents 647c7d8 + a977357 commit b14df6e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

binding_generator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2745,12 +2745,12 @@ def correct_typed_dictionary(type_name):
27452745
def correct_type(type_name, meta=None, use_alias=True):
27462746
type_conversion = {"float": "double", "int": "int64_t", "Nil": "Variant"}
27472747
if meta is not None:
2748-
if "int" in meta:
2748+
if meta in ["int8", "int16", "int32", "int64", "uint8", "uint16", "uint32", "uint64"]:
27492749
return f"{meta}_t"
2750-
elif "char" in meta:
2751-
return f"{meta}_t"
2752-
else:
2750+
elif meta in ["float", "double"]:
27532751
return meta
2752+
elif meta in ["char16", "char32"]:
2753+
return f"{meta}_t"
27542754
if type_name in type_conversion:
27552755
return type_conversion[type_name]
27562756
if type_name.startswith("typedarray::"):

0 commit comments

Comments
 (0)