Skip to content
This repository was archived by the owner on Jun 14, 2019. It is now read-only.

Commit 567ee6c

Browse files
committed
rename func
1 parent 1a34f46 commit 567ee6c

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

builder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ func (b *Builder) ToSQL() (string, []interface{}, error) {
245245
}
246246

247247
// ToBoundSQL
248-
func (b *Builder) ToBindedSQL() (string, error) {
248+
func (b *Builder) ToBoundSQL() (string, error) {
249249
w := NewWriter()
250250
if err := b.WriteTo(w); err != nil {
251251
return "", err

builder_limit_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ func TestBuilder_Limit4Mssql(t *testing.T) {
1919

2020
// simple -- MsSQL style
2121
sql, err := Dialect(MSSQL).Select("a", "b", "c").From("table1").
22-
OrderBy("a ASC").Limit(5).ToBindedSQL()
22+
OrderBy("a ASC").Limit(5).ToBoundSQL()
2323
assert.NoError(t, err)
2424
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT TOP 5 a,b,c,ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS RN FROM table1 ORDER BY a ASC) at", sql)
2525
assert.NoError(t, f.executableCheck(sql))
2626

2727
// simple with where -- MsSQL style
2828
sql, err = Dialect(MSSQL).Select("a", "b", "c").From("table1").
29-
Where(Neq{"a": "3"}).OrderBy("a ASC").Limit(5, 10).ToBindedSQL()
29+
Where(Neq{"a": "3"}).OrderBy("a ASC").Limit(5, 10).ToBoundSQL()
3030
assert.NoError(t, err)
3131
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT TOP 15 a,b,c,ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS RN FROM table1 WHERE a<>'3' ORDER BY a ASC) at WHERE at.RN>10", sql)
3232
assert.NoError(t, f.executableCheck(sql))
@@ -36,7 +36,7 @@ func TestBuilder_Limit4Mssql(t *testing.T) {
3636
Dialect(MSSQL).Select("a", "b", "c").From("table1").Where(Neq{"a": "1"}).
3737
OrderBy("a ASC").Limit(5, 6).Union("ALL",
3838
Select("a", "b", "c").From("table1").Where(Neq{"b": "2"}).OrderBy("a DESC").Limit(10))).
39-
OrderBy("b DESC").Limit(7, 9).ToBindedSQL()
39+
OrderBy("b DESC").Limit(7, 9).ToBoundSQL()
4040
assert.NoError(t, err)
4141
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT TOP 16 a,b,c,ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS RN FROM ((SELECT a,b,c FROM (SELECT TOP 11 a,b,c,ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS RN FROM table1 WHERE a<>'1' ORDER BY a ASC) at WHERE at.RN>6) UNION ALL (SELECT a,b,c FROM (SELECT TOP 10 a,b,c,ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS RN FROM table1 WHERE b<>'2' ORDER BY a DESC) at)) at ORDER BY b DESC) at WHERE at.RN>9", sql)
4242
assert.NoError(t, f.executableCheck(sql))
@@ -51,21 +51,21 @@ func TestBuilder_Limit4MysqlLike(t *testing.T) {
5151

5252
// simple -- MySQL/SQLite/PostgreSQL style
5353
sql, err := Dialect(MYSQL).Select("a", "b", "c").From("table1").OrderBy("a ASC").
54-
Limit(5, 10).ToBindedSQL()
54+
Limit(5, 10).ToBoundSQL()
5555
assert.NoError(t, err)
5656
assert.EqualValues(t, "SELECT a,b,c FROM table1 ORDER BY a ASC LIMIT 5 OFFSET 10", sql)
5757
assert.NoError(t, f.executableCheck(sql))
5858

5959
// simple -- MySQL/SQLite/PostgreSQL style
6060
sql, err = Dialect(MYSQL).Select("a", "b", "c").From("table1").
61-
OrderBy("a ASC").Limit(5).ToBindedSQL()
61+
OrderBy("a ASC").Limit(5).ToBoundSQL()
6262
assert.NoError(t, err)
6363
assert.EqualValues(t, "SELECT a,b,c FROM table1 ORDER BY a ASC LIMIT 5", sql)
6464
assert.NoError(t, f.executableCheck(sql))
6565

6666
// simple with where -- MySQL/SQLite/PostgreSQL style
6767
sql, err = Dialect(MYSQL).Select("a", "b", "c").From("table1").
68-
Where(Eq{"a": "1", "b": "1"}).OrderBy("a ASC").Limit(5, 10).ToBindedSQL()
68+
Where(Eq{"a": "1", "b": "1"}).OrderBy("a ASC").Limit(5, 10).ToBoundSQL()
6969
assert.NoError(t, err)
7070
assert.EqualValues(t, "SELECT a,b,c FROM table1 WHERE a='1' AND b='1' ORDER BY a ASC LIMIT 5 OFFSET 10", sql)
7171
assert.NoError(t, f.executableCheck(sql))
@@ -75,7 +75,7 @@ func TestBuilder_Limit4MysqlLike(t *testing.T) {
7575
Dialect(MYSQL).Select("a", "b", "c").From("table1").Where(Eq{"a": "1"}).OrderBy("a ASC").
7676
Limit(5, 9).Union("ALL",
7777
Select("a", "b", "c").From("table1").Where(Eq{"a": "2"}).OrderBy("a DESC").Limit(10))).
78-
Limit(5, 10).ToBindedSQL()
78+
Limit(5, 10).ToBoundSQL()
7979
assert.NoError(t, err)
8080
assert.EqualValues(t, "SELECT a,b,c FROM ((SELECT a,b,c FROM table1 WHERE a='1' ORDER BY a ASC LIMIT 5 OFFSET 9) UNION ALL (SELECT a,b,c FROM table1 WHERE a='2' ORDER BY a DESC LIMIT 10)) at LIMIT 5 OFFSET 10", sql)
8181
assert.NoError(t, f.executableCheck(sql))
@@ -90,28 +90,28 @@ func TestBuilder_Limit4Oracle(t *testing.T) {
9090

9191
// simple -- OracleSQL style
9292
sql, err := Dialect(ORACLE).Select("a", "b", "c").From("table1").OrderBy("a ASC").
93-
Limit(5, 10).ToBindedSQL()
93+
Limit(5, 10).ToBoundSQL()
9494
assert.NoError(t, err)
9595
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT * FROM (SELECT a,b,c,ROWNUM RN FROM table1 ORDER BY a ASC) at WHERE at.RN<=15) att WHERE att.RN>10", sql)
9696
assert.NoError(t, f.executableCheck(sql))
9797

9898
// simple with join -- OracleSQL style
9999
sql, err = Dialect(ORACLE).Select("a", "b", "c", "d").From("table1 t1").
100-
InnerJoin("table2 t2", "t1.id = t2.ref_id").OrderBy("a ASC").Limit(5, 10).ToBindedSQL()
100+
InnerJoin("table2 t2", "t1.id = t2.ref_id").OrderBy("a ASC").Limit(5, 10).ToBoundSQL()
101101
assert.NoError(t, err)
102102
assert.EqualValues(t, "SELECT a,b,c,d FROM (SELECT * FROM (SELECT a,b,c,d,ROWNUM RN FROM table1 t1 INNER JOIN table2 t2 ON t1.id = t2.ref_id ORDER BY a ASC) at WHERE at.RN<=15) att WHERE att.RN>10", sql)
103103
assert.NoError(t, f.executableCheck(sql))
104104

105105
// simple -- OracleSQL style
106106
sql, err = Dialect(ORACLE).Select("a", "b", "c").From("table1").
107-
OrderBy("a ASC").Limit(5).ToBindedSQL()
107+
OrderBy("a ASC").Limit(5).ToBoundSQL()
108108
assert.NoError(t, err)
109109
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT a,b,c,ROWNUM RN FROM table1 ORDER BY a ASC) at WHERE at.RN<=5", sql)
110110
assert.NoError(t, f.executableCheck(sql))
111111

112112
// simple with where -- OracleSQL style
113113
sql, err = Dialect(ORACLE).Select("a", "b", "c").From("table1").Where(Neq{"a": "10", "b": "20"}).
114-
OrderBy("a ASC").Limit(5, 1).ToBindedSQL()
114+
OrderBy("a ASC").Limit(5, 1).ToBoundSQL()
115115
assert.NoError(t, err)
116116
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT * FROM (SELECT a,b,c,ROWNUM RN FROM table1 WHERE a<>'10' AND b<>'20' ORDER BY a ASC) at WHERE at.RN<=6) att WHERE att.RN>1", sql)
117117
assert.NoError(t, f.executableCheck(sql))
@@ -122,7 +122,7 @@ func TestBuilder_Limit4Oracle(t *testing.T) {
122122
Where(Neq{"a": "0"}).OrderBy("a ASC").Limit(5, 10).Union("ALL",
123123
Select("a", "b", "c").From("table1").Where(Neq{"b": "48"}).
124124
OrderBy("a DESC").Limit(10))).
125-
Limit(3).ToBindedSQL()
125+
Limit(3).ToBoundSQL()
126126
assert.NoError(t, err)
127127
assert.EqualValues(t, "SELECT a,b,c FROM (SELECT a,b,c,ROWNUM RN FROM ((SELECT a,b,c FROM (SELECT * FROM (SELECT a,b,c,ROWNUM RN FROM table1 WHERE a<>'0' ORDER BY a ASC) at WHERE at.RN<=15) att WHERE att.RN>10) UNION ALL (SELECT a,b,c FROM (SELECT a,b,c,ROWNUM RN FROM table1 WHERE b<>'48' ORDER BY a DESC) at WHERE at.RN<=10)) at) at WHERE at.RN<=3", sql)
128128
assert.NoError(t, f.executableCheck(sql))

builder_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,8 @@ func TestExprCond(t *testing.T) {
442442
assert.EqualValues(t, []interface{}{1, 2, 3, 4}, args)
443443
}
444444

445-
func TestBuilderToBindedSQL(t *testing.T) {
446-
newSQL, err := Select("id").From("table").Where(In("a", 1, 2)).ToBindedSQL()
445+
func TestBuilderToBoundSQL(t *testing.T) {
446+
newSQL, err := Select("id").From("table").Where(In("a", 1, 2)).ToBoundSQL()
447447
assert.NoError(t, err)
448448
assert.EqualValues(t, "SELECT id FROM table WHERE a IN (1,2)", newSQL)
449449
}

sql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func ToBoundSQL(cond interface{}) (string, error) {
5151
case Cond:
5252
return condToBoundSQL(cond.(Cond))
5353
case *Builder:
54-
return cond.(*Builder).ToBindedSQL()
54+
return cond.(*Builder).ToBoundSQL()
5555
}
5656
return "", ErrNotSupportType
5757
}

sql_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func (f *fiddler) executableCheck(obj interface{}) error {
116116
var err error
117117
switch obj.(type) {
118118
case *Builder:
119-
sql, err = obj.(*Builder).ToBindedSQL()
119+
sql, err = obj.(*Builder).ToBoundSQL()
120120
if err != nil {
121121
return err
122122
}

0 commit comments

Comments
 (0)