Skip to content

Remove all code related support of version 1 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 25, 2019
Merged

Remove all code related support of version 1 #237

merged 7 commits into from
Aug 25, 2019

Conversation

jaedle
Copy link
Contributor

@jaedle jaedle commented Aug 13, 2019 •
edited
Loading

Pull request for cleanup task Remove all code related support of version 1

Changes:

  • versions prior to version 2 are not supported anymore ==> error on parsing of those files
  • files without any version information are considered as version 1
  • all tests specific related to version 1 are removed
  • all test fixtures are converted to version 2
  • documentation states that version 1 is deprecated
  • inline example on task cli help is updated to version 2

Ready for review :)

If I missed anything, please tell me!
@jaedle jaedle changed the title [WIP] remove v1 remove v1 Aug 18, 2019
@andreynering andreynering changed the title remove v1 Remove all code related support of version 1 Aug 18, 2019
@andreynering andreynering added this to the v3 milestone Aug 18, 2019
andreynering
andreynering reviewed Aug 18, 2019
View reviewed changes
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jaedle,

Thanks for opening this pull request! You did a pretty good job here.

I did a couple of comments, and then this is good to merge.
@andreynering andreynering mentioned this pull request Aug 18, 2019
Closed
18 tasks
jaedle and others added 5 commits August 19, 2019 20:53
@jaedle
Copy link
Contributor Author

jaedle commented Aug 19, 2019

I hope that is now good to go! :)

I also bumped the version of the auto generated taskfile to version 3. I hope that was fine! :)
@andreynering
Copy link
Member

Awesome!

Thanks again @jaedle!
@andreynering andreynering merged commit 1b8998e into go-task:v3 Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jaedle @andreynering