fix: disable version check for use as an external library #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andreynering approved these changes Dec 7, 2024
pd93 reviewed Dec 7, 2024
There was a problem hiding this comment.
Thanks for this @leaanthony.
Just a thought before this is merged. I don't think we should require users of our library to set a DisableVersionCheck flag to make Task work as package. I feel like this should be the default behaviour and our CLI entrypoint should enable it instead (basically, the reverse of this PR).
| I actually agree with you. This got me over the line but yeah adding the in the CLI and not |
leaanthony changed the title | @pd93 - Updated the PR to run the version initialisation on cli startup. Tidied the version output if there is no sum. |
pd93 reviewed Dec 8, 2024
leaanthony force-pushed the disable-version-check-flag branch from 504a0da to 89e7b35 Compare pd93 reviewed Dec 29, 2024
pd93 reviewed Dec 29, 2024
Comment on lines +61 to +62
| // Initialise version | ||
| ver.Init() |
There was a problem hiding this comment.
No longer required after the discussed changes
andreynering changed the title andreynering added a commit that referenced this pull request Jan 18, 2025
| Thanks @leaanthony. Manually merged as 69f5714. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds an internal flag to the executor to disable version checks. This is to ensure that any application that uses Task as a library doesn't error when Task checks the buildinfo.
This PR also renames
closetocloserintask.goas it clashes with the keyword `close.