feat: add TASK_OFFLINE env and expose it as a special variable #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vmaerten force-pushed the feat/add-offline-env branch from ee9e593 to 1868040 Compare 
pd93 requested changes Sep 20, 2024
Co-authored-by: Pete Davison <pd93.uk@outlook.com>
I agree. I think, I'll take some times to draft a PR to add more override like this |
pd93 reviewed Sep 20, 2024
vmaerten force-pushed the feat/add-offline-env branch from 1bbc4d9 to a33f797 Compare vmaerten added a commit that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Two things in this PR (very correlated) :
TASK_OFFLINEenv variable to control--offlineflag. Is it useful when you want to use--offlineall the time. And also, It will be picked up by the autocomplete without modifying the autocomplete file (related to refactor: check if the remote exists just before reading it #1713)The CLI flags takes precedences over the env variable, this way we can override it as needed
CLI_OFFLINEto expose this flag to the templating system (closes Feature Request: provide a bool variable to tasks that represents if the —offline flag is used #1470)