Add zsh completion #111
Merged
Add zsh completion #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I think this looks like a nice start. Longer term, it might be slightly better to go for a self-completing program (see e.g. https://github.com/posener/complete) so that the completion options and program flags does not need to be maintained several places. |
| Hi @sawadashota Thanks for your contribution! This will definitely improve the UX, specially if we can integrate it with Homebrew and Snapcraft. @smyrman Yeah, we can consider that in the future, but until that happen I'll accept this one. 🙂 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to #103
Put file like
docker/clihttps://github.com/docker/cli/blob/master/contrib/completion/zsh/_docker