Skip to content

Commit 9b7959f

Browse files
committed
golint cleanup
1 parent d432719 commit 9b7959f

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

encode_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ func TestMarshalKeyvals(t *testing.T) {
125125
if err != d.err {
126126
t.Errorf("%#v: got error: %v, want error: %v", d.in, err, d.err)
127127
}
128-
if got, want := got, d.want; !reflect.DeepEqual(got, want) {
129-
t.Errorf("%#v: got '%s', want '%s'", d.in, got, want)
128+
if !reflect.DeepEqual(got, d.want) {
129+
t.Errorf("%#v: got '%s', want '%s'", d.in, got, d.want)
130130
}
131131
}
132132
}
@@ -181,12 +181,12 @@ func (t marshalerStringer) String() string {
181181
return fmt.Sprint(t.a + t.b)
182182
}
183183

184-
var marshalError = errors.New("marshal error")
184+
var errMarshal = errors.New("marshal error")
185185

186186
type errorMarshaler struct{}
187187

188188
func (errorMarshaler) MarshalText() ([]byte, error) {
189-
return nil, marshalError
189+
return nil, errMarshal
190190
}
191191

192192
func BenchmarkEncodeKeyval(b *testing.B) {

fuzz.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,22 @@ import (
1212
kr "github.com/kr/logfmt"
1313
)
1414

15+
// Fuzz checks reserialized data matches
1516
func Fuzz(data []byte) int {
1617
parsed, err := parse(data)
1718
if err != nil {
1819
return 0
1920
}
2021
var w1 bytes.Buffer
21-
if err := write(parsed, &w1); err != nil {
22+
if err = write(parsed, &w1); err != nil {
2223
panic(err)
2324
}
2425
parsed, err = parse(data)
2526
if err != nil {
2627
panic(err)
2728
}
2829
var w2 bytes.Buffer
29-
if err := write(parsed, &w2); err != nil {
30+
if err = write(parsed, &w2); err != nil {
3031
panic(err)
3132
}
3233
if !bytes.Equal(w1.Bytes(), w2.Bytes()) {
@@ -35,6 +36,7 @@ func Fuzz(data []byte) int {
3536
return 1
3637
}
3738

39+
// FuzzVsKR checks go-logfmt/logfmt against kr/logfmt
3840
func FuzzVsKR(data []byte) int {
3941
parsed, err := parse(data)
4042
parsedKR, errKR := parseKR(data)

0 commit comments

Comments
 (0)