Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d37f246
Add reviewers selection to new pull request form
splitt3r Aug 19, 2023
5929b87
Add translatanle clear reviewers label
splitt3r Aug 19, 2023
452828a
Add missing continue statement
splitt3r Aug 19, 2023
906514e
Check pr creator permissions
splitt3r Sep 1, 2023
45b8a96
Remove unintended change
splitt3r Sep 1, 2023
3e0dcea
Check if Pull + run linter
splitt3r Sep 9, 2023
978c465
Fix invisible class name
sebastian-sauer Oct 20, 2023
c92202e
Add request review to API
sebastian-sauer Oct 20, 2023
df3f363
Fix call to locale in tmpl
sebastian-sauer Nov 15, 2023
e4858b2
Improve markup
sebastian-sauer Nov 15, 2023
f604ab1
Fix teamreviewer ids
sebastian-sauer Nov 15, 2023
60d9d96
update template to merge main
CalK16 Oct 31, 2024
f7c0ea4
move logics to proper file
CalK16 Nov 2, 2024
c34dd4a
postpone the review request notification
CalK16 Nov 2, 2024
f7f0b7a
Merge branch 'main' into main
CalK16 Nov 2, 2024
0304324
fix linting issues
CalK16 Nov 2, 2024
800232b
more updates on templates
CalK16 Nov 3, 2024
d8d66b5
simplify a condition statement
CalK16 Nov 3, 2024
25ebf69
fix an internal error
CalK16 Nov 3, 2024
418a13c
Merge branch 'main' into CalK16-pr-reviewer
wxiaoguang Nov 3, 2024
941f7fd
fix conflicts
wxiaoguang Nov 3, 2024
a2a06f1
Merge branch 'main' into CalK16-pr-reviewer
wxiaoguang Nov 8, 2024
8de6e40
make code easier to maintain
wxiaoguang Nov 8, 2024
6fb9583
fix duplicate code
wxiaoguang Nov 8, 2024
e4e2de3
refactor reviewer list
wxiaoguang Nov 8, 2024
637e4fb
fix lint
wxiaoguang Nov 8, 2024
4c9169a
Merge branch 'main' into CalK16-pr-reviewer
wxiaoguang Nov 8, 2024
9ccb69c
fix lint
wxiaoguang Nov 8, 2024
1759ea4
fine tune
wxiaoguang Nov 8, 2024
be102f5
fine tune and add comments
wxiaoguang Nov 9, 2024
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into CalK16-pr-reviewer
# Conflicts: #	templates/repo/issue/view_content/sidebar.tmpl
  • Loading branch information
wxiaoguang committed Nov 8, 2024
commit a2a06f16504882a8d02732b6be4f3e464f9fb33a
81 changes: 3 additions & 78 deletions templates/repo/issue/view_content/sidebar.tmpl
Original file line number Diff line number Diff line change
@@ -1,84 +1,9 @@
<div class="issue-content-right ui segment">
{{template "repo/issue/branch_selector_field" $}}

<div class="ui assignees list">
<span class="no-select item {{if or .OriginalReviews .PullReviewers}}tw-hidden{{end}}">{{ctx.Locale.Tr "repo.issues.new.no_reviewers"}}</span>
<div class="selected">
{{range .PullReviewers}}
<div class="item tw-flex tw-items-center tw-py-2">
<div class="tw-flex tw-items-center tw-flex-1">
{{if .User}}
<a class="muted sidebar-item-link" href="{{.User.HomeLink}}">{{ctx.AvatarUtils.Avatar .User 28 "tw-mr-2"}}{{.User.GetDisplayName}}</a>
{{else if .Team}}
<span class="text">{{svg "octicon-people" 20 "tw-mr-2"}}{{$.Issue.Repo.OwnerName}}/{{.Team.Name}}</span>
{{end}}
</div>
<div class="tw-flex tw-items-center tw-gap-2">
{{if (and $.Permission.IsAdmin (or (eq .Review.Type 1) (eq .Review.Type 3)) (not $.Issue.IsClosed) (not $.Issue.PullRequest.HasMerged))}}
<a href="#" class="ui muted icon tw-flex tw-items-center show-modal" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.dismiss_review"}}" data-modal="#dismiss-review-modal-{{.Review.ID}}">
{{svg "octicon-x" 20}}
</a>
<div class="ui small modal" id="dismiss-review-modal-{{.Review.ID}}">
<div class="header">
{{ctx.Locale.Tr "repo.issues.dismiss_review"}}
</div>
<div class="content">
<div class="ui warning message">
{{ctx.Locale.Tr "repo.issues.dismiss_review_warning"}}
</div>
<form class="ui form dismiss-review-form" id="dismiss-review-{{.Review.ID}}" action="{{$.RepoLink}}/issues/dismiss_review" method="post">
{{$.CsrfTokenHtml}}
<input type="hidden" name="review_id" value="{{.Review.ID}}">
<div class="field">
<label for="message">{{ctx.Locale.Tr "action.review_dismissed_reason"}}</label>
<input id="message" name="message">
</div>
<div class="text right actions">
<button class="ui cancel button">{{ctx.Locale.Tr "settings.cancel"}}</button>
<button class="ui red button" type="submit">{{ctx.Locale.Tr "ok"}}</button>
</div>
</form>
</div>
</div>
{{end}}
{{if .Review.Stale}}
<span data-tooltip-content="{{ctx.Locale.Tr "repo.issues.is_stale"}}">
{{svg "octicon-hourglass" 16}}
</span>
{{end}}
{{if and .CanChange (or .Checked (and (not $.Issue.IsClosed) (not $.Issue.PullRequest.HasMerged)))}}
<a href="#" class="ui muted icon re-request-review{{if .Checked}} checked{{end}}" data-tooltip-content="{{if .Checked}}{{ctx.Locale.Tr "repo.issues.remove_request_review"}}{{else}}{{ctx.Locale.Tr "repo.issues.re_request_review"}}{{end}}" data-issue-id="{{$.Issue.ID}}" data-id="{{.ItemID}}" data-update-url="{{$.RepoLink}}/issues/request_review">{{svg (Iif .Checked "octicon-trash" "octicon-sync")}}</a>
{{end}}
<span {{if .Review.TooltipContent}}data-tooltip-content="{{ctx.Locale.Tr .Review.TooltipContent}}"{{end}}>
{{svg (printf "octicon-%s" .Review.Type.Icon) 16 (printf "text %s" (.Review.HTMLTypeColorName))}}
</span>
</div>
</div>
{{end}}
{{range .OriginalReviews}}
<div class="item tw-flex tw-items-center tw-py-2">
<div class="tw-flex tw-items-center tw-flex-1">
<a class="muted" href="{{$.Repository.OriginalURL}}" data-tooltip-content="{{ctx.Locale.Tr "repo.migrated_from_fake" $.Repository.GetOriginalURLHostname}}">
{{svg (MigrationIcon $.Repository.GetOriginalURLHostname) 20 "tw-mr-2"}}
{{.OriginalAuthor}}
</a>
</div>
<div class="tw-flex tw-items-center tw-gap-2">
<span {{if .TooltipContent}}data-tooltip-content="{{ctx.Locale.Tr .TooltipContent}}"{{end}}>
{{svg (printf "octicon-%s" .Type.Icon) 16 (printf "text %s" (.HTMLTypeColorName))}}
</span>
</div>
</div>
{{end}}
</div>
</div>
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .HasMerged) (not .Issue.IsClosed) (not .IsPullWorkInProgress)}}
<div class="toggle-wip" data-title="{{.Issue.Title}}" data-wip-prefix="{{index .PullRequestWorkInProgressPrefixes 0}}" data-update-url="{{.Issue.Link}}/title">
<a class="muted">
{{ctx.Locale.Tr "repo.pulls.still_in_progress"}} {{ctx.Locale.Tr "repo.pulls.add_prefix" (index .PullRequestWorkInProgressPrefixes 0)}}
</a>
</div>
{{end}}
{{if .Issue.IsPull}}
{{template "repo/issue/sidebar/reviewer_list" $}}
{{template "repo/issue/sidebar/wip_switch" $}}
<div class="divider"></div>
{{end}}

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.