Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/git/signature_gogit.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ type Signature = object.Signature
func newSignatureFromCommitline(line []byte) (_ *Signature, err error) {
sig := new(Signature)
emailStart := bytes.IndexByte(line, '<')
sig.Name = string(line[:emailStart-1])
if emailStart > 0 { // Empty name has already occurred, even if it shouldn't
sig.Name = string(line[:emailStart-1])
}
emailEnd := bytes.IndexByte(line, '>')
sig.Email = string(line[emailStart+1 : emailEnd])

Expand Down
4 changes: 3 additions & 1 deletion modules/git/signature_nogogit.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ func newSignatureFromCommitline(line []byte) (sig *Signature, err error) {
return
}

sig.Name = string(line[:emailStart-1])
if emailStart > 0 { // Empty name has already occurred, even if it shouldn't
sig.Name = string(line[:emailStart-1])
}
sig.Email = string(line[emailStart+1 : emailEnd])

hasTime := emailEnd+2 < len(line)
Expand Down