Skip to content

Refactor ref type #33242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 14, 2025
Merged

Refactor ref type #33242

merged 10 commits into from
Jan 14, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 13, 2025 •
edited
Loading

Use git.RefType instead of a new type definition RepoRefType on context.

I reverted other changes about routers since the router doesn't look beautiful.
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 13, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/api This PR adds API routes or modifies them modifies/dependencies and removed modifies/templates This PR modifies the template files labels Jan 13, 2025
@lunny lunny force-pushed the lunny/refactor_reftype branch from 068a612 to 5399b03 Compare January 14, 2025 00:23
@github-actions github-actions bot removed modifies/api This PR adds API routes or modifies them modifies/dependencies labels Jan 14, 2025
@lunny lunny marked this pull request as ready for review January 14, 2025 00:27
@wxiaoguang
Copy link
Contributor

There were many abuses in old code (for example: context.RepoRefByTypeOptions{IgnoreNotExistErr: true})

Will do some more fixes.
@wxiaoguang
Merge branch 'main' into lunny/refactor_reftype
5191149 
# Conflicts: #	routers/web/web.go
@wxiaoguang wxiaoguang force-pushed the lunny/refactor_reftype branch from 625757c to c2e8dfc Compare January 14, 2025 02:09
@wxiaoguang wxiaoguang marked this pull request as draft January 14, 2025 02:09
@wxiaoguang wxiaoguang force-pushed the lunny/refactor_reftype branch 5 times, most recently from 8168888 to 1f2ca31 Compare January 14, 2025 05:53
@wxiaoguang wxiaoguang force-pushed the lunny/refactor_reftype branch from 1f2ca31 to c1aa3b9 Compare January 14, 2025 05:56
wxiaoguang
wxiaoguang reviewed Jan 14, 2025
View reviewed changes
@wxiaoguang
Copy link
Contributor

Major changes:

  1. do not sync ".keep" file during tests
  2. fix incorrect route handler and empty repo handling (backported as Fix tag route and empty repo #33253 with tests)
  3. do not use RepoRef: most of the calls are abuses.
@wxiaoguang wxiaoguang marked this pull request as ready for review January 14, 2025 06:35
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@lunny lunny merged commit 6410c34 into go-gitea:main Jan 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 14, 2025
@wxiaoguang wxiaoguang deleted the lunny/refactor_reftype branch January 14, 2025 07:35
@wxiaoguang
Copy link
Contributor

-> Simplify context ref name #33267
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ceae9c4 
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix some broken route handlers (go-gitea#33268) Add a confirm dialog for "sync fork" (go-gitea#33270) Fix sidebar milestone link (go-gitea#33269) Refactor ref type (go-gitea#33242) Fix 500 error when error occurred in migration page (go-gitea#33256) Fix missing license when sync mirror (go-gitea#33255)
@kemzeb kemzeb mentioned this pull request Jan 16, 2025
Closed
@wxiaoguang wxiaoguang mentioned this pull request Apr 6, 2025
Merged
lafriks pushed a commit that referenced this pull request Apr 6, 2025
@wxiaoguang
Remove dead code: RepoRef (#34131)
3fe082a 
The RepoRef is a no-op since Refactor ref type (#33242) (Jan 14)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

4 participants

@lunny @wxiaoguang @hiifong @GiteaBot