Add telemetry for untyped expressions and missing call targets

Author: smowton

java/ql/src/Telemetry/ExtractorInformation.ql

@@ -85,6 +85,67 @@ predicate extractorTotalDiagnostics(string key, int value) {
  )
 }
 
+signature module StatsSig {
+ int getNumberOfOk();
+
+ int getNumberOfNotOk();
+
+ string getOkText();
+
+ string getNotOkText();
+}
+
+module ReportStats<StatsSig Stats> {
+ predicate numberOfOk(string key, int value) {
+ value = Stats::getNumberOfOk() and
+ key = "Number of " + Stats::getOkText()
+ }
+
+ predicate numberOfNotOk(string key, int value) {
+ value = Stats::getNumberOfNotOk() and
+ key = "Number of " + Stats::getNotOkText()
+ }
+
+ predicate percentageOfOk(string key, float value) {
+ value = Stats::getNumberOfOk() * 100.0 / (Stats::getNumberOfOk() + Stats::getNumberOfNotOk()) and
+ key = "Percentage of " + Stats::getOkText()
+ }
+}
+
+module CallTargetStats implements StatsSig {
+ int getNumberOfOk() { result = count(Call c | exists(c.getCallee())) }
+
+ int getNumberOfNotOk() { result = count(Call c | not exists(c.getCallee())) }
+
+ string getOkText() { result = "calls with call target" }
+
+ string getNotOkText() { result = "calls with missing call target" }
+}
+
+private class SourceExpr extends Expr {
+ SourceExpr() {
+ this.getFile().isSourceFile()
+ }
+}
+
+private predicate hasGoodType(Expr e) {
+ exists(e.getType()) and not e.getType() instanceof ErrorType
+}
+
+module ExprTypeStats implements StatsSig {
+ int getNumberOfOk() { result = count(SourceExpr e | hasGoodType(e)) }
+
+ int getNumberOfNotOk() { result = count(SourceExpr e | not hasGoodType(e)) }
+
+ string getOkText() { result = "expressions with known type" }
+
+ string getNotOkText() { result = "expressions with unknown type" }
+}
+
+module CallTargetStatsReport = ReportStats<CallTargetStats>;
+
+module ExprTypeStatsReport = ReportStats<ExprTypeStats>;
+
 from string key, int value
 where
  not exists(string pattern | extractorInformationSkipKey(pattern) and key.matches(pattern)) and
@@ -97,6 +158,12 @@ where
  totalNumberOfLinesByExtension(key, value) or
  numberOfLinesOfCodeByExtension(key, value) or
  extractorDiagnostics(key, value) or
- extractorTotalDiagnostics(key, value)
+ extractorTotalDiagnostics(key, value) or
+ CallTargetStatsReport::numberOfOk(key, value) or
+ CallTargetStatsReport::numberOfNotOk(key, value) or
+ CallTargetStatsReport::percentageOfOk(key, value) or
+ ExprTypeStatsReport::numberOfOk(key, value) or
+ ExprTypeStatsReport::numberOfNotOk(key, value) or
+ ExprTypeStatsReport::percentageOfOk(key, value)
  )
 select key, value