feat(ai): improve AI provider integration and configuration handling

- Introduced 'systemPrompt' in 'OpenAIProvider' to enable configurable system messages - Refactored 'NewOpenAIProvider' to accept 'systemPrompt' for more contextual AI responses - Replaced 'Provider' interface definition in 'ai/provider.go' with a structured 'types.Provider' - Enhanced 'Config' to expose getter methods for AI configuration values - Added default values for AI settings, including a default system prompt - Created 'internal/types/common.go' to define AI provider interface and configuration abstraction

Author: gifflet

cmd/review.go

@@ -18,6 +18,12 @@ func formatCommitHash(hash string) string {
 
 // executeReview executes the main logic of the program
 func executeReview() {
+// provider, err := AppConfig.GetAIProvider()
+// if err != nil {
+//	fmt.Printf("Error getting AI provider: %v\n", err)
+//	os.Exit(1)
+// }
+
 // Format commit hashes
 initialCommit = formatCommitHash(initialCommit)
 

cmd/root.go

@@ -20,7 +20,7 @@ var (
 AppVersion = "dev"
 
 // Configuration
-appConfig *config.Config
+AppConfig *config.Config
 
 // Root command
 rootCmd = &cobra.Command{
@@ -55,7 +55,7 @@ changes between Git commits.`,
 
 // SetConfig sets the application configuration
 func SetConfig(cfg *config.Config) {
-appConfig = cfg
+AppConfig = cfg
 }
 
 // InitializeFlags parses command line flags before executing the main command

internal/ai/openai.go

@@ -3,25 +3,38 @@ package ai
 import (
 "context"
 
+"github.com/gifflet/git-review/internal/types"
 "github.com/tmc/langchaingo/llms"
 "github.com/tmc/langchaingo/llms/openai"
 )
 
 type OpenAIProvider struct {
-llm llms.LLM
+llm llms.LLM
+systemPrompt string
 }
 
-func NewOpenAIProvider(token, model string) (Provider, error) {
+func NewOpenAIProvider(token, model, systemPrompt string) (types.Provider, error) {
 llm, err := openai.New(
 openai.WithToken(token),
 openai.WithModel(model),
 )
 if err != nil {
 return nil, err
 }
-return &OpenAIProvider{llm: llm}, nil
+return &OpenAIProvider{
+llm: llm,
+systemPrompt: systemPrompt,
+}, nil
 }
 
 func (p *OpenAIProvider) Generate(ctx context.Context, prompt string) (string, error) {
-return llms.GenerateFromSinglePrompt(ctx, p.llm, prompt)
+content := []llms.MessageContent{
+llms.TextParts(llms.ChatMessageTypeSystem, p.systemPrompt),
+llms.TextParts(llms.ChatMessageTypeHuman, prompt),
+}
+completion, err := p.llm.GenerateContent(ctx, content)
+if err != nil {
+return "", err
+}
+return completion.Choices[0].Content, nil
 }

internal/ai/provider.go

@@ -1,20 +1,16 @@
 package ai
 
 import (
-"context"
 "fmt"
-)
 
-// Provider defines the interface for AI providers
-type Provider interface {
-Generate(ctx context.Context, prompt string) (string, error)
-}
+"github.com/gifflet/git-review/internal/types"
+)
 
 // NewProvider creates a new AI provider based on configuration
-func NewProvider(providerName, token, model string) (Provider, error) {
+func NewProvider(providerName string, c types.AIConfig) (types.Provider, error) {
 switch providerName {
 case "openai":
-return NewOpenAIProvider(token, model)
+return NewOpenAIProvider(c.GetOpenAIToken(), c.GetOpenAIModel(), c.GetSystemPrompt())
 default:
 return nil, fmt.Errorf("unsupported AI provider: %s", providerName)
 }

internal/config/config.go

@@ -6,6 +6,7 @@ import (
 "path/filepath"
 
 "github.com/gifflet/git-review/internal/ai"
+"github.com/gifflet/git-review/internal/types"
 "github.com/spf13/viper"
 )
 
@@ -15,15 +16,27 @@ type Config struct {
 Provider string `mapstructure:"provider"`
 OpenAI struct {
 Token string `mapstructure:"token"`
-Model string `mapstructure:"model" default:"gpt-4o"`
+Model string `mapstructure:"model"`
 } `mapstructure:"openai"`
+SystemPrompt string `mapstructure:"system_prompt"`
 } `mapstructure:"ai"`
 }
 
+func (c *Config) GetOpenAIToken() string {
+return c.AI.OpenAI.Token
+}
+
+func (c *Config) GetOpenAIModel() string {
+return c.AI.OpenAI.Model
+}
+
+func (c *Config) GetSystemPrompt() string {
+return c.AI.SystemPrompt
+}
+
 // GetAIProvider creates a new AI provider based on configuration
-func (c *Config) GetAIProvider() (ai.Provider, error) {
-cfg := c.AI
-return ai.NewProvider(cfg.Provider, cfg.OpenAI.Token, cfg.OpenAI.Model)
+func (c *Config) GetAIProvider() (types.Provider, error) {
+return ai.NewProvider(c.AI.Provider, c)
 }
 
 // LoadConfig reads configuration from files and environment variables
@@ -34,6 +47,11 @@ func LoadConfig(projectPath string) (*Config, error) {
 v.SetConfigName("config")
 v.SetConfigType("yaml")
 
+// Set default values
+v.SetDefault("ai.provider", "openai")
+v.SetDefault("ai.openai.model", "gpt-4o")
+v.SetDefault("ai.system_prompt", "You are a helpful assistant that reviews code changes. You are given a git diff with the changes made to the code. You need to review the changes and provide a list of potential improvements.")
+
 // Add global config paths
 homeDir, err := os.UserHomeDir()
 if err != nil {

internal/types/common.go

@@ -0,0 +1,15 @@
+package types
+
+import "context"
+
+// Provider defines the interface for AI providers
+type Provider interface {
+Generate(ctx context.Context, prompt string) (string, error)
+}
+
+// AIConfig holds the configuration for AI providers
+type AIConfig interface {
+GetOpenAIToken() string
+GetOpenAIModel() string
+GetSystemPrompt() string
+}