Skip to content

Commit eeb2e1f

Browse files
committed
fix minor indentation in readme
1 parent 2971517 commit eeb2e1f

File tree

2 files changed

+20
-21
lines changed

2 files changed

+20
-21
lines changed

5-AccessControl/2-call-api-groups/AppCreationScripts/Configure.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -400,10 +400,10 @@ Function ConfigureApplications
400400

401401
$newClaim = CreateOptionalClaim -name "groups"
402402
$optionalClaims.IdToken += ($newClaim)
403-
# $newClaim = CreateOptionalClaim -name "groups"
404-
# $optionalClaims.AccessToken += ($newClaim)
405-
# $newClaim = CreateOptionalClaim -name "groups"
406-
# $optionalClaims.Saml2Token += ($newClaim)
403+
$newClaim = CreateOptionalClaim -name "groups"
404+
$optionalClaims.AccessToken += ($newClaim)
405+
$newClaim = CreateOptionalClaim -name "groups"
406+
$optionalClaims.Saml2Token += ($newClaim)
407407

408408
# Add Optional Claims
409409

5-AccessControl/2-call-api-groups/README.md

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
page_type: sample
33
name: Angular single-page application calling a protected ASP.NET Core web API and using Security Groups to implement Role-Based Access Control
44
description: An Angular single-page application calling a protected AspNet web API and using Security Groups to implement Role-Based Access Control (RBAC)
5-
- languages:
6-
- typescript
7-
- csharp
8-
- javascript
5+
languages:
6+
- typescript
7+
- csharp
8+
- javascript
99
products:
10-
- azure-active-directory
11-
- ms-graph
12-
- msal-js
13-
- msal-angular
14-
- microsoft-identity-web
10+
- azure-active-directory
11+
- ms-graph
12+
- msal-js
13+
- msal-angular
14+
- microsoft-identity-web
1515
urlFragment: ms-identity-javascript-angular-tutorial
1616
extensions:
1717
- services: ms-identity
@@ -39,7 +39,7 @@ extensions:
3939

4040
This sample demonstrates a cross-platform application suite involving an Angular single-page application (*TodoListSPA*) calling an ASP.NET Core web API (*TodoListAPI*) secured with the Microsoft identity platform. In doing so, it implements **Role-based Access Control** (RBAC) by using Azure AD **[Security Groups](https://learn.microsoft.com/azure/active-directory/fundamentals/how-to-manage-groups)**.
4141

42-
Role based access control in Azure AD can be done with **Delegated** and **App** permissions and **App Roles** as well. We will cover RBAC using App Roles in the E:\github\Azure-Samples\ms-identity-javascript-angular-tutorial\5-AccessControl\2-call-api-groups\README.md. **Delegated** and **App** permissions, **Security Groups** and **App Roles** in Azure AD are by no means mutually exclusive - they can be used in tandem to provide even finer grained access control.
42+
Role based access control in Azure AD can be done with **Delegated** and **App** permissions and **App Roles** as well. We will cover RBAC using App Roles in the [previous tutorial](../1-call-api-roles/README.md). **Delegated** and **App** permissions, **Security Groups** and **App Roles** in Azure AD are by no means mutually exclusive - they can be used in tandem to provide even finer grained access control.
4343

4444
In the sample, a dashboard component allows signed-in users to see the tasks assigned to them or other users based on their memberships to one of the two security groups, **GroupAdmin** and **GroupMember**.
4545

@@ -203,20 +203,19 @@ To manually register the apps, as a first step you'll need to:
203203
##### Grant Delegated Permissions to msal-angular-app
204204
205205
1. Since this app signs-in users, we will now proceed to select **delegated permissions**, which is is required by apps signing-in users.
206-
1. In the app's registration screen, select the **API permissions** blade in the left to open the page where we add access to the APIs that your application needs:
206+
1. In the app's registration screen, select the **API permissions** blade in the left to open the page where we add access to the APIs that your application needs:
207207
1. Select the **Add a permission** button and then:
208208
1. Ensure that the **My APIs** tab is selected.
209209
1. In the list of APIs, select the API `msal-angular-app`.
210-
* Since this app signs-in users, we will now proceed to select **delegated permissions**, which is requested by apps that signs-in users.
211-
* In the **Delegated permissions** section, select **access_via_group_assignments** in the list. Use the search box if necessary.
210+
1. In the **Delegated permissions** section, select **access_via_group_assignments** in the list. Use the search box if necessary.
212211
1. Select the **Add permissions** button at the bottom.
213212
1. Select the **Add a permission** button and then:
214213
1. Ensure that the **Microsoft APIs** tab is selected.
215214
1. In the *Commonly used Microsoft APIs* section, select **Microsoft Graph**
216-
* Since this app signs-in users, we will now proceed to select **delegated permissions**, which is requested by apps that signs-in users.
217-
* In the **Delegated permissions** section, select **User.Read**, **GroupMember.Read.All** in the list. Use the search box if necessary.
215+
1. In the **Delegated permissions** section, select **User.Read**, **GroupMember.Read.All** in the list. Use the search box if necessary.
218216
1. Select the **Add permissions** button at the bottom.
219-
> :warning: To handle the groups overage scenario, please grant [admin consent](https://learn.microsoft.com/azure/active-directory/manage-apps/grant-admin-consent?source=recommendations#grant-admin-consent-in-app-registrations) to the Microsoft Graph **GroupMember.Read.All** [permission](https://learn.microsoft.com/graph/permissions-reference). See the section on how to [create the overage scenario for testing](#create-the-overage-scenario-for-testing) below for more.
217+
218+
> :warning: To handle the groups overage scenario, please grant [admin consent](https://learn.microsoft.com/azure/active-directory/manage-apps/grant-admin-consent?source=recommendations#grant-admin-consent-in-app-registrations) to the Microsoft Graph **GroupMember.Read.All** [permission](https://learn.microsoft.com/graph/permissions-reference). See the section on how to [create the overage scenario for testing](#create-the-overage-scenario-for-testing) below for more.
220219
221220
##### Configure Optional Claims
222221
@@ -396,7 +395,7 @@ If a user is member of more groups than the overage limit (**150 for SAML tokens
396395
397396
#### Create the Overage Scenario for testing
398397

399-
1. You can use the [BulkCreateGroups.ps1](./AppCreationScripts/BulkCreateGroups.ps1) provided in the [App Creation Scripts](./AppCreationScripts/) folder to create a large number of groups and assign users to them. This will help test overage scenarios during development. You'll need to enter a user'S Object ID when prompted by the `BulkCreateGroups.ps1` script. If you would like to delete these groups after your testing, run the [BulkRemoveGroups.ps1](./AppCreationScripts/BulkRemoveGroups.ps1).
398+
1. You can use the [BulkCreateGroups.ps1](./AppCreationScripts/BulkCreateGroups.ps1) provided in the [App Creation Scripts](./AppCreationScripts/) folder to create a large number of groups and assign users to them. This will help test overage scenarios during development. You'll need to enter a user's object ID when prompted by the `BulkCreateGroups.ps1` script. If you would like to delete these groups after your testing, run the [BulkRemoveGroups.ps1](./AppCreationScripts/BulkRemoveGroups.ps1).
400399

401400
> When attending to overage scenarios, which requires a call to [Microsoft Graph](https://graph.microsoft.com) to read the signed-in user's group memberships, your app will need to have the [User.Read](https://docs.microsoft.com/graph/permissions-reference#user-permissions) and [GroupMember.Read.All](https://docs.microsoft.com/graph/permissions-reference#group-permissions) for the [getMemberGroups](https://docs.microsoft.com/graph/api/user-getmembergroups) function to execute successfully.
402401

0 commit comments

Comments
 (0)