minor refactor

Author: derisen

5-AccessControl/2-call-api-groups/README.md

@@ -539,7 +539,7 @@ public static async Task ProcessAnyGroupsOverage(TokenValidatedContext context)
 
 #### Caching user group memberships in overage scenario
 
-Since overaged tokens will not contain group membership IDs, yet these IDs are required for controlling access to pages and/or resources, applications have to call Microsoft Graph whenever a user action (e.g. accessing a page on the UI, accessing a todolist item in the web API etc.) takes place. These network calls are costly and will impact the application performance and user experience. As such, both the SPA and web API projects here would benefit from caching the group membership IDs once they are fetched from Microsoft Graph for the first time. By default, these are cached for 1 hour in the sample. Cached groups will miss any changes to a users group membership for this duration. If you need more fine grained control, you can configure cache duration in [auth-config.ts](./SPA/src/app/auth-config.ts) for the SPA and in [appsettings.json](./API/TodoListAPI/appsettings.json) for the web API. If your scenario requires capturing real-time changes to a user's group membership, consider implementing [Microsoft Graph change notifications](https://learn.microsoft.com/graph/api/resources/webhooks) instead.
+Since overaged tokens will not contain group membership IDs, yet these IDs are required for controlling access to pages and/or resources, applications have to call Microsoft Graph whenever a user action (e.g. accessing a page on the UI, accessing a todolist item in the web API etc.) takes place. These network calls are costly and will impact the application performance and user experience. As such, both the SPA and web API projects here would benefit from caching the group membership IDs once they are fetched from Microsoft Graph for the first time. By default, these are cached for **1 hour** in the sample. Cached groups will miss any changes to a users group membership for this duration. If you need more fine grained control, you can configure cache duration in [auth-config.ts](./SPA/src/app/auth-config.ts) for the SPA and in [appsettings.json](./API/TodoListAPI/appsettings.json) for the web API. If your scenario requires capturing real-time changes to a user's group membership, consider implementing [Microsoft Graph change notifications](https://learn.microsoft.com/graph/api/resources/webhooks) instead.
 
 ##### Group authorization policy
 

5-AccessControl/2-call-api-groups/SPA/src/app/graph.service.ts

@@ -50,7 +50,7 @@ export class GraphService {
  }
 
  async getFilteredGroups(filterGroups: string[] = []): Promise<string[]> {
- const groups: string[] = [];
+ let groups: string[] = [];
 
  try {
  const accessToken = await this.getToken(protectedResources.apiGraph.scopes);
@@ -64,7 +64,8 @@ export class GraphService {
  groupIds: filterGroups
  });
 
- return response.value;
+ groups = response.value;
+ return groups;
  } catch (error) {
  console.log(error);
  }