🚸 reworked waiting animation logic

Author: ggthedev

docker-manager.sh

@@ -138,10 +138,16 @@ route_operation() {
  source "$SCRIPT_DIR/operations/cleanup.sh"
  cleanup_multiple_containers "${CONTAINER_NAMES[@]}" "$FORCE"
  else
- local container_name=$(get_target_container)
- print_section "Cleaning up container: $container_name"
- source "$SCRIPT_DIR/operations/cleanup.sh"
- cleanup_container "$container_name" "$FORCE"
+ # No container specified - check if we have a last container
+ local last_container=$(get_last_container)
+ if [[ -n "$last_container" ]]; then
+ print_section "Cleaning up container: $last_container"
+ source "$SCRIPT_DIR/operations/cleanup.sh"
+ cleanup_container "$last_container" "$FORCE"
+ else
+ print_error "No containers to clean up"
+ exit 1
+ fi
  fi
  ;;
  "nuke")
@@ -438,29 +444,7 @@ handle_restart() {
  fi
 }
 
-# =============================================================================
-# FUNCTION: handle_cleanup
-# =============================================================================
-# Purpose: Handle the cleanup operation to remove containers and images
-# Inputs: None (uses global variables CONTAINER_NAME, FORCE)
-# Outputs: None
-# Side Effects: 
-# - Sources and calls cleanup operation module
-# - Handles both single container cleanup and full system cleanup
-# Usage: Called by route_operation when operation is "cleanup"
-# =============================================================================
-handle_cleanup() {
- if [[ "$CONTAINER_NAME" == "--all" ]]; then
- print_section "Cleaning up all Docker resources"
- cleanup_docker "$FORCE"
- else
- local container_name=$(get_target_container)
- print_section "Cleaning up container: $container_name"
- 
- source "$SCRIPT_DIR/operations/cleanup.sh"
- cleanup_container "$container_name" "$FORCE"
- fi
-}
+
 
 # =============================================================================
 # FUNCTION: handle_status
@@ -506,10 +490,19 @@ handle_status() {
 # Usage: Called by route_operation when operation is "logs"
 # =============================================================================
 handle_logs() {
- local containers=($(get_target_containers))
- 
- if [[ ${#containers[@]} -eq 1 ]]; then
- local container_name="${containers[0]}"
+ if [[ ${#CONTAINER_NAMES[@]} -eq 0 ]]; then
+ # No container specified - check if we have a last container
+ local last_container=$(get_last_container)
+ if [[ -n "$last_container" ]]; then
+ print_section "Logs for container: $last_container"
+ source "$SCRIPT_DIR/operations/logs.sh"
+ show_container_logs "$last_container"
+ else
+ print_error "No containers to show logs for"
+ exit 1
+ fi
+ elif [[ ${#CONTAINER_NAMES[@]} -eq 1 ]]; then
+ local container_name="${CONTAINER_NAMES[0]}"
  print_section "Logs for container: $container_name"
 
  source "$SCRIPT_DIR/operations/logs.sh"
@@ -518,7 +511,7 @@ handle_logs() {
  print_section "Logs for multiple containers"
 
  source "$SCRIPT_DIR/operations/logs.sh"
- show_multiple_containers_logs "${containers[@]}"
+ show_multiple_containers_logs "${CONTAINER_NAMES[@]}"
  fi
 }
 

docs/Notes.md

@@ -144,4 +144,111 @@ Both operations now support the `--no-start` flag:
 - **Generate**: Uses `generate_from_yaml()` function that processes YAML files directly
 - **Install**: Uses `install_container()` function that calls `generate_from_yaml()` with stored YAML path
 - **State Management**: Both operations update the state file with container metadata
-- **--no-start Flag**: Both operations respect the flag to create containers without starting them 
+- **--no-start Flag**: Both operations respect the flag to create containers without starting them
+
+---
+
+# Animation Display Issue Fix
+
+## Problem Statement
+During container generation, extraneous characters (specifically "i") were appearing in the output after progress animations. The issue manifested as:
+
+```
+...ℹ Waiting for container 'nginx-app-container' to be ready (timeout: 60s)
+```
+
+Where the dots (`...`) from the animation were not being properly cleared before the next message was printed, causing visual artifacts.
+
+## Root Cause Analysis
+The issue was caused by race conditions in the animation system:
+
+1. **Line Clearing Logic**: The `printf "\r%*s\r"` commands were using dynamic width calculations that weren't working correctly
+2. **Timing Issues**: There was insufficient delay between stopping animations and printing the next message
+3. **Animation State**: The signal-based animation system wasn't properly clearing the terminal line before new content was displayed
+
+## Solution Approach
+
+### 1. Fixed Line Clearing Logic
+**Problem**: Dynamic width calculations in `printf "\r%*s\r" $((dots_count + 1)) ""` were unreliable
+**Solution**: Changed to fixed width of 80 characters: `printf "\r%*s\r" 80 ""`
+
+**Files Modified**:
+- `lib/utils.sh`: Updated all animation functions to use consistent line clearing
+
+### 2. Added Explicit Line Clearing
+**Problem**: Race conditions between animation stopping and next message printing
+**Solution**: Added explicit line clearing before showing waiting messages
+
+**Files Modified**:
+- `lib/container_ops.sh`: Added `printf "\r%*s\r" 80 ""` before `print_info` calls
+
+### 3. Added Timing Delays
+**Problem**: Insufficient time for animations to fully clear
+**Solution**: Added small delays (`sleep 0.1`) after stopping animations
+
+**Files Modified**:
+- `lib/container_ops.sh`: Added delays after `stop_signal_animation` calls
+- `lib/utils.sh`: Enhanced `stop_signal_animation` with additional line clearing
+
+### 4. Enhanced Animation Cleanup
+**Problem**: Animation processes weren't properly cleaning up terminal state
+**Solution**: Added explicit line clearing in animation cleanup functions
+
+## Implementation Details
+
+### Key Changes Made
+
+1. **Consistent Line Clearing**:
+ ```bash
+ # Before (problematic)
+ printf "\r%*s\r" $((dots_count + 1)) ""
+ 
+ # After (fixed)
+ printf "\r%*s\r" 80 ""
+ ```
+
+2. **Explicit Pre-Message Clearing**:
+ ```bash
+ # Ensure any previous animation is fully cleared
+ printf "\r%*s\r" 80 ""
+ print_info "Waiting for container '$container_name' to be ready..."
+ ```
+
+3. **Animation Stop Delays**:
+ ```bash
+ stop_signal_animation
+ # Small delay to ensure animation is fully cleared
+ sleep 0.1
+ ```
+
+4. **Enhanced Cleanup**:
+ ```bash
+ # Ensure line is cleared after animation stops
+ printf "\r%*s\r" 80 ""
+ ```
+
+## Testing Results
+
+**Before Fix**:
+```
+...ℹ Waiting for container 'nginx-app-container' to be ready (timeout: 60s)
+```
+
+**After Fix**:
+```
+ℹ Waiting for container 'nginx-app-container' to be ready (timeout: 60s)
+```
+
+## Lessons Learned
+
+1. **Terminal Animation Timing**: Even small race conditions can cause visual artifacts
+2. **Line Clearing Consistency**: Using fixed widths is more reliable than dynamic calculations
+3. **Animation State Management**: Proper cleanup is essential for multi-step processes
+4. **User Experience**: Clean output is crucial for professional tool appearance
+
+## Future Considerations
+
+- Consider implementing a more robust animation system with better state management
+- Add animation debugging capabilities for troubleshooting similar issues
+- Consider using a dedicated terminal library for complex animations
+- Implement animation queuing to prevent overlapping animations 

lib/container_ops.sh

@@ -903,6 +903,9 @@ wait_for_container_ready() {
  local start_time=$(date +%s)
  local end_time=$((start_time + timeout))
 
+ # Ensure any previous animation is fully cleared
+ printf "\r%*s\r" 80 ""
+ 
  # Show waiting animation
  print_info "Waiting for container '$container_name' to be ready (timeout: ${timeout}s)"
 
@@ -926,6 +929,8 @@ wait_for_container_ready() {
  # If healthy, stop animation and return success
  if [[ "$health_status" == "healthy" ]]; then
  stop_signal_animation
+ # Small delay to ensure animation is fully cleared
+ sleep 0.1
  log_operation_success "$operation" "$container_name" "Container is healthy and ready"
  return 0
  elif [[ "$health_status" == "unhealthy" ]]; then
@@ -948,6 +953,8 @@ wait_for_container_ready() {
 
  # Timeout reached - stop animation
  stop_signal_animation
+ # Small delay to ensure animation is fully cleared
+ sleep 0.1
 
  # After timeout, check if container is running and show appropriate message
  local is_running=$(container_is_running "$container_name" && echo "true" || echo "false")

lib/utils.sh

@@ -560,7 +560,7 @@ show_dots_animation() {
  done
 
  # Clear the line
- printf "\r%*s\r" $(( ${#message} + max_dots + 1 )) ""
+ printf "\r%*s\r" 80 ""
 }
 
 # Show simple dots animation only
@@ -578,7 +578,7 @@ show_waiting_dots() {
  # Show one cycle of dots animation
  for ((i=0; i<=max_dots; i++)); do
  # Clear previous dots and show current state
- printf "\r%*s\r" $(( max_dots + 1 )) ""
+ printf "\r%*s\r" 80 ""
  for ((j=0; j<i; j++)); do
  printf "."
  done
@@ -648,7 +648,7 @@ show_waiting_animation() {
  done
 
  # Clear the line when done
- printf "\r%*s\r" $(( ${#message} + 10 )) ""
+ printf "\r%*s\r" 80 ""
 }
 
 # Show waiting animation with condition
@@ -681,7 +681,7 @@ show_waiting_animation_with_condition() {
  if [[ $((current_time - last_check_time)) -ge $check_interval ]]; then
  if eval "$condition_command" >/dev/null 2>&1; then
  # Clear the line when condition is met
- printf "\r%*s\r" $(( ${#message} + 10 )) ""
+ printf "\r%*s\r" 80 ""
  return 0
  fi
  last_check_time=$current_time
@@ -697,7 +697,7 @@ show_waiting_animation_with_condition() {
  done
 
  # Clear the line when timeout occurs
- printf "\r%*s\r" $(( ${#message} + 10 )) ""
+ printf "\r%*s\r" 80 ""
  return 1
 }
 
@@ -744,7 +744,7 @@ start_signal_animation() {
  # Start animation in background process
  (
  # Set up signal handler for this process
- trap 'rm -f "$signal_file"; printf "\r%*s\r" $((dots_count + 1)) ""; exit 0' SIGUSR1 EXIT
+ trap 'rm -f "$signal_file"; printf "\r%*s\r" 80 ""; exit 0' SIGUSR1 EXIT
 
  # Run animation until signal file is created or signal received
  while [[ ! -f "$signal_file" ]]; do
@@ -753,7 +753,7 @@ start_signal_animation() {
 
  # Clean up and exit
  rm -f "$signal_file"
- printf "\r%*s\r" $((dots_count + 1)) ""
+ printf "\r%*s\r" 80 ""
  ) &
 
  _ANIMATION_PID=$!
@@ -810,6 +810,9 @@ stop_signal_animation() {
  _ANIMATION_SIGNAL_RECEIVED=false
  _ANIMATION_SIGNAL_FILE=""
 
+ # Ensure line is cleared after animation stops
+ printf "\r%*s\r" 80 ""
+ 
  log_debug "ANIMATION" "" "Signal-based animation stopped"
  fi
 }
@@ -1296,4 +1299,77 @@ send_notification() {
  fi
 }
 
+# =============================================================================
+# PROGRESS INDICATORS FOR CONTAINER GENERATION
+# =============================================================================
+
+# Show generation progress with animation
+# Displays animated progress messages for container generation steps
+# Provides visual feedback during the generation process
+#
+# Input:
+# $1 - step: The current step (1-4)
+# $2 - yaml_file: The YAML file being processed
+# $3 - container_name: The container name being generated
+# Output: Animated progress message to stdout
+# Example: show_generation_progress 1 "docker-compose.yml" "nginx"
+show_generation_progress() {
+ local step="$1"
+ local yaml_file="$2"
+ local container_name="$3"
+ 
+ case "$step" in
+ 1)
+ printf "\r%s" "📋 Extracting config from $(basename "$yaml_file")"
+ show_waiting_dots 3
+ ;;
+ 2)
+ printf "\r%s" "🔧 Generating docker-compose file"
+ show_waiting_dots 3
+ ;;
+ 3)
+ printf "\r%s" "🐳 Creating container '$container_name'"
+ show_waiting_dots 3
+ ;;
+ 4)
+ printf "\r%s" "✅ Finalizing container setup"
+ show_waiting_dots 3
+ ;;
+ esac
+}
+
+# Show generation step completion
+# Displays a completion message for each generation step
+# Clears the progress line and shows completion status
+#
+# Input:
+# $1 - step: The completed step (1-4)
+# $2 - yaml_file: The YAML file being processed
+# $3 - container_name: The container name being generated
+# Output: Completion message to stdout
+# Example: show_generation_step_complete 1 "docker-compose.yml" "nginx"
+show_generation_step_complete() {
+ local step="$1"
+ local yaml_file="$2"
+ local container_name="$3"
+ 
+ # Clear the progress line
+ printf "\r%*s\r" 80 ""
+ 
+ case "$step" in
+ 1)
+ print_success "Config extracted from $(basename "$yaml_file")"
+ ;;
+ 2)
+ print_success "Docker-compose file generated"
+ ;;
+ 3)
+ print_success "Container '$container_name' created"
+ ;;
+ 4)
+ print_success "Container setup completed"
+ ;;
+ esac
+}
+