fix(logging): Send raw logging parameters #4291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
szokeasaurusrex requested review from antonpirker and removed request for a team 
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@ ## master #4291 +/- ## ========================================== + Coverage 79.50% 79.53% +0.03% ========================================== Files 142 142 Lines 15907 15907 Branches 2723 2722 -1 ========================================== + Hits 12647 12652 +5 + Misses 2391 2389 -2 + Partials 869 866 -3
|
This reverts commit 4c9731b, adding tests to ensure the correct behavior going forward. That commit caused a regression when `record.args` contains a dictionary. Because we iterate over `record.args`, that change caused us to only send the dictionary's keys, not the values. A more robust fix for #3660 will be to send the formatted message in the [`formatted` field](https://develop.sentry.dev/sdk/data-model/event-payloads/message/) (which we have not been doing yet). I will open a follow-up PR to do this. Fixes #4267
szokeasaurusrex force-pushed the szokeasaurusrex/send-raw-logging-args branch from f327c77 to e71ccbf Compare szokeasaurusrex added a commit that referenced this pull request Apr 14, 2025
Send the formatted log event to Sentry in the [`formatted` field](https://develop.sentry.dev/sdk/data-model/event-payloads/message/). This builds on #4291, providing a more robust fix for #3660.
szokeasaurusrex added a commit that referenced this pull request Apr 15, 2025
Send the formatted log event to Sentry in the [`formatted` field](https://develop.sentry.dev/sdk/data-model/event-payloads/message/). This builds on #4291, providing a more robust fix for #3660.
szokeasaurusrex added a commit that referenced this pull request Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
sentrivana approved these changes Apr 15, 2025
szokeasaurusrex added a commit that referenced this pull request Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
antonpirker pushed a commit that referenced this pull request Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This reverts commit 4c9731b, adding tests to ensure the correct behavior going forward.
That commit caused a regression when
record.argscontains a dictionary. Because we iterate overrecord.args, that change caused us to only send the dictionary's keys, not the values.A more robust fix for #3660 will be to send the formatted message in the
formattedfield (which we have not been doing yet). I will open a follow-up PR to do this.Fixes #4267