eslint: merge no-missing-args-validator + no-args-without-validator into one rule (#42036)

This pull request merges rules `@convex-dev/no-missing-args-validator` and `@convex-dev/no-args-without-validator` into one new rule: `@convex-dev/require-argument-validators`. The rule is customizable with an option named `ignoreUnusedArguments`, that allows the user to select whether they want to tolerate functions that don’t define argument validators but don’t use arguments. This option is _disabled_ by default, i.e. we force every function to have a return validator. I also changed the rule so that it behaves correctly with the old syntax. GitOrigin-RevId: 23aaa9835fc9d0682bc680518f6263c723bb8e84

Author: Nicolapps

npm-packages/@convex-dev/eslint-plugin/src/index.ts

@@ -1,13 +1,12 @@
 import { noImportUseNode } from "./lib/noImportUseNode.js";
 import noOldRegisteredFunctionSyntax from "./lib/noOldRegisteredFunctionSyntax.js";
-import { noMissingArgs, noArgsWithoutValidator } from "./lib/noMissingArgs.js";
+import { requireArgsValidator } from "./lib/requireArgsValidator.js";
 import { RuleModule } from "@typescript-eslint/utils/ts-eslint";
 import { version } from "./version.js";
 
 const rules = {
  "no-old-registered-function-syntax": noOldRegisteredFunctionSyntax,
- "no-args-without-validator": noArgsWithoutValidator,
- "no-missing-args-validator": noMissingArgs,
+ "require-args-validator": requireArgsValidator,
  "import-wrong-runtime": noImportUseNode,
 } satisfies Record<string, RuleModule<string, unknown[]>>;
 
@@ -17,12 +16,7 @@ const recommendedRules = {
  // file if all Node.js-specific imports are side-effect free.
  "@convex-dev/import-wrong-runtime": "off",
  "@convex-dev/no-old-registered-function-syntax": "error",
- // This is a reasonable idea in large projects: throw at runtime
- // when API endpoints that don't expect arguments receive them.
- // But it lacks the typical benefit of a validator providing
- // types so it feels more pedantic.
- "@convex-dev/no-missing-args-validator": "off",
- "@convex-dev/no-args-without-validator": "error",
+ "@convex-dev/require-args-validator": "error",
 } satisfies {
  [key: `@convex-dev/${string}`]: "error" | "warn" | "off";
 };