Skip to content

Commit 6cd987e

Browse files
malfetfacebook-github-bot
authored andcommitted
Make fully_qualified_type_name_impl() compatible with VS2017 15.9 (pytorch#31455)
Summary: Pull Request resolved: pytorch#31455 In 15.9, __FUNCSIG__ unwraps using definitions as well as preserves noexcept qualifiers Test Plan: Build caffe2 on Windows using VS2017 Differential Revision: D19166204 fbshipit-source-id: b6c5f70e5262d13adf585f77b92223cf5f1e78dd
1 parent 2099cfa commit 6cd987e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

c10/util/TypeIndex.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ template <typename T>
6060
inline C10_TYPENAME_CONSTEXPR string_view fully_qualified_type_name_impl() noexcept {
6161
#if defined(_MSC_VER) && !defined(__clang__)
6262
return extract(
63-
"class c10::string_view __cdecl c10::util::detail::fully_qualified_type_name_impl<",
64-
">(void)",
63+
"class c10::basic_string_view<char> __cdecl c10::util::detail::fully_qualified_type_name_impl<",
64+
">(void) noexcept",
6565
__FUNCSIG__);
6666
#elif defined(__clang__)
6767
return extract(

0 commit comments

Comments
 (0)