Skip to content

Commit ba2fa95

Browse files
moiseshiraldolmtierney
authored andcommitted
Add service_args to Firefox WebDriver (SeleniumHQ#5421)
The Firefox Geckodirver Service accepts the service_args parameter, but there is no way of passing those service arguments from the Firefox WebDriver. Fixes SeleniumHQ#5420
1 parent c1beae5 commit ba2fa95

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

py/selenium/webdriver/firefox/webdriver.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ class WebDriver(RemoteWebDriver):
5656
def __init__(self, firefox_profile=None, firefox_binary=None,
5757
timeout=30, capabilities=None, proxy=None,
5858
executable_path="geckodriver", options=None,
59-
log_path="geckodriver.log", firefox_options=None):
59+
log_path="geckodriver.log", firefox_options=None,
60+
service_args=None):
6061
"""Starts a new local session of Firefox.
6162
6263
Based on the combination and specificity of the various keyword
@@ -144,7 +145,10 @@ def __init__(self, firefox_profile=None, firefox_binary=None,
144145

145146
if capabilities.get("marionette"):
146147
capabilities.pop("marionette")
147-
self.service = Service(executable_path, log_path=log_path)
148+
self.service = Service(
149+
executable_path,
150+
service_args=service_args,
151+
log_path=log_path)
148152
self.service.start()
149153

150154
capabilities.update(options.to_capabilities())

0 commit comments

Comments
 (0)