Exposing HostName property for .NET DriverService class

Previously, the host name for a DriverService was hard-coded to be "localhost." This is normally acceptable, as a DriverService is only intended to be used locally, and most executables that are represented by a DriverService (chromedriver, geckodriver, IEDriverServer.exe, etc.) do not even allow connections from external machines. However, there is a legitimate use case (.NET Standard 2.0) where a local IP address ("127.0.0.1" or "::1") is preferrable to using the "localhost" moniker. This HostName property allows the user to specify that IP address. Note that the property defaults to "localhost," preserving previous behavior.

Author: jimevans

dotnet/src/webdriver/DriverService.cs

@@ -1,4 +1,4 @@
-// <copyright file="DriverService.cs" company="WebDriver Committers">
+// <copyright file="DriverService.cs" company="WebDriver Committers">
 // Licensed to the Software Freedom Conservancy (SFC) under one
 // or more contributor license agreements. See the NOTICE file
 // distributed with this work for additional information
@@ -34,6 +34,7 @@ public abstract class DriverService : ICommandServer
  {
  private string driverServicePath;
  private string driverServiceExecutableName;
+ private string driverServiceHostName = "localhost";
  private int driverServicePort;
  private bool silent;
  private bool hideCommandPromptWindow;
@@ -75,7 +76,21 @@ protected DriverService(string servicePath, int port, string driverServiceExecut
  /// </summary>
  public Uri ServiceUrl
  {
- get { return new Uri(string.Format(CultureInfo.InvariantCulture, "http://localhost:{0}", this.driverServicePort)); }
+ get { return new Uri(string.Format(CultureInfo.InvariantCulture, "http://{0}:{1}", this.driverServiceHostName, this.driverServicePort)); }
+ }
+
+ /// <summary>
+ /// Gets or sets the host name of the service. Defaults to "localhost."
+ /// </summary>
+ /// <remarks>
+ /// Most driver service executables do not allow connections from remote
+ /// (non-local) machines. This property can be used as a workaround so
+ /// that an IP address (like "127.0.0.1" or "::1") can be used instead.
+ /// </remarks>
+ public string HostName
+ {
+ get { return this.driverServiceHostName; }
+ set { this.driverServiceHostName = value; }
  }
 
  /// <summary>