Skip to content
This repository was archived by the owner on Jun 5, 2021. It is now read-only.
This repository was archived by the owner on Jun 5, 2021. It is now read-only.

Some rules will be incompatible with Bazel 0.27 #56

@apt-itude

Description

@apt-itude

The use of the the single_file attribute is deprecated and should be replaced by allow_single_file (see bazelbuild/bazel#5818).

Certain rules such as npm_packages still use this attribute, so building produces this error:

ERROR: /Users/athompson/.cache/bazel/_bazel_athompson/13d84619eb7379140847c87225e1148e/external/bazel_javascript/internal/npm_packages/rule.bzl:38:25: Traceback (most recent call last): File "/Users/athompson/.cache/bazel/_bazel_athompson/13d84619eb7379140847c87225e1148e/external/bazel_javascript/internal/npm_packages/rule.bzl", line 36 rule(attrs = {"package_json": attr.la..."))}, <2 more arguments>) File "/Users/athompson/.cache/bazel/_bazel_athompson/13d84619eb7379140847c87225e1148e/external/bazel_javascript/internal/npm_packages/rule.bzl", line 38, in rule attr.label(allow_files = True, single_file = ..., ...) 'single_file' is no longer supported. use allow_single_file instead. You can use --incompatible_disable_deprecated_attr_params=false to temporarily disable this check. 

This is not a dealbreaker for the time being since Bazel 0.27 has not even been release yet and the --incompatible_disable_deprecated_attr_params flag will allow us to disable that check if we need to, but I just wanted to get ahead of it.

The issue linked above claims that these attributes can be automatically fixed using buildifier --lint=fix, so that may be all that's necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions