Skip to content

Commit d08522f

Browse files
committed
[MLIR][Preburger] fix typo covertVarKind -> convertVarKind
Also update parameter names in the implementation file to match the header.
1 parent 333620d commit d08522f

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

mlir/include/mlir/Analysis/Presburger/IntegerRelation.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -481,11 +481,12 @@ class IntegerRelation {
481481
/// position `pos` of dstKind, otherwise they are placed after all the other
482482
/// variables of kind dstKind. The internal ordering among the moved variables
483483
/// is preserved.
484-
void covertVarKind(VarKind srcKind, unsigned varStart, unsigned varLimit,
485-
VarKind dstKind, unsigned pos);
484+
void convertVarKind(VarKind srcKind, unsigned varStart, unsigned varLimit,
485+
VarKind dstKind, unsigned pos);
486486
void convertVarKind(VarKind srcKind, unsigned varStart, unsigned varLimit,
487487
VarKind dstKind) {
488-
covertVarKind(srcKind, varStart, varLimit, dstKind, getNumVarKind(dstKind));
488+
convertVarKind(srcKind, varStart, varLimit, dstKind,
489+
getNumVarKind(dstKind));
489490
}
490491
void convertToLocal(VarKind kind, unsigned varStart, unsigned varLimit) {
491492
convertVarKind(kind, varStart, varLimit, VarKind::Local);

mlir/lib/Analysis/Presburger/IntegerRelation.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,16 +1262,16 @@ void IntegerRelation::removeRedundantLocalVars() {
12621262
}
12631263
}
12641264

1265-
void IntegerRelation::covertVarKind(VarKind srcKind, unsigned idStart,
1266-
unsigned idLimit, VarKind dstKind,
1267-
unsigned pos) {
1268-
assert(idLimit <= getNumVarKind(srcKind) && "Invalid id range");
1265+
void IntegerRelation::convertVarKind(VarKind srcKind, unsigned varStart,
1266+
unsigned varLimit, VarKind dstKind,
1267+
unsigned pos) {
1268+
assert(varLimit <= getNumVarKind(srcKind) && "Invalid id range");
12691269

1270-
if (idStart >= idLimit)
1270+
if (varStart >= varLimit)
12711271
return;
12721272

12731273
// Append new local variables corresponding to the dimensions to be converted.
1274-
unsigned convertCount = idLimit - idStart;
1274+
unsigned convertCount = varLimit - varStart;
12751275
unsigned newVarsBegin = insertVar(dstKind, pos, convertCount);
12761276

12771277
// Swap the new local variables with dimensions.
@@ -1283,10 +1283,10 @@ void IntegerRelation::covertVarKind(VarKind srcKind, unsigned idStart,
12831283
// created ids we're swapping with were zero-initialized).
12841284
unsigned offset = getVarKindOffset(srcKind);
12851285
for (unsigned i = 0; i < convertCount; ++i)
1286-
swapVar(offset + idStart + i, newVarsBegin + i);
1286+
swapVar(offset + varStart + i, newVarsBegin + i);
12871287

12881288
// Complete the move by deleting the initially occupied columns.
1289-
removeVarRange(srcKind, idStart, idLimit);
1289+
removeVarRange(srcKind, varStart, varLimit);
12901290
}
12911291

12921292
void IntegerRelation::addBound(BoundType type, unsigned pos, int64_t value) {
@@ -2225,7 +2225,7 @@ void IntegerRelation::compose(const IntegerRelation &rel) {
22252225
appendVar(VarKind::Range, copyRel.getNumRangeVars());
22262226

22272227
// Convert R2 to B X C.
2228-
copyRel.covertVarKind(VarKind::Domain, 0, numBVars, VarKind::Range, 0);
2228+
copyRel.convertVarKind(VarKind::Domain, 0, numBVars, VarKind::Range, 0);
22292229

22302230
// Intersect R2 to range of R1.
22312231
intersectRange(IntegerPolyhedron(copyRel));

0 commit comments

Comments
 (0)