[Java] Allow a length to be set that is greater than provided constant and NUL pad remainder. Issue aeron-io#463.

Author: mjpt777

sbe-tool/src/main/java/uk/co/real_logic/sbe/PrimitiveValue.java

@@ -250,12 +250,18 @@ public static PrimitiveValue parse(
  public static PrimitiveValue parse(
  final String value, final int length, final String characterEncoding)
  {
- if (value.length() != length)
+ if (value.length() > length)
  {
- throw new IllegalStateException("value.length=" + value.length() + " not equal to length=" + length);
+ throw new IllegalStateException("value.length=" + value.length() + " greater than length=" + length);
  }
 
- return new PrimitiveValue(value.getBytes(forName(characterEncoding)), characterEncoding, length);
+ byte[] bytes = value.getBytes(forName(characterEncoding));
+ if (bytes.length < length)
+ {
+ bytes = Arrays.copyOf(bytes, length);
+ }
+
+ return new PrimitiveValue(bytes, characterEncoding, length);
  }
 
  /**

sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/EncodedDataType.java

@@ -64,7 +64,8 @@ public EncodedDataType(final Node node, final String givenName)
  super(node, givenName, null);
 
  primitiveType = PrimitiveType.get(getAttributeValue(node, "primitiveType"));
- length = Integer.parseInt(getAttributeValue(node, "length", "1"));
+ final String lengthAttr = getAttributeValueOrNull(node, "length");
+ length = Integer.parseInt(null == lengthAttr ? "1" : lengthAttr);
  varLen = Boolean.parseBoolean(getAttributeValue(node, "variableLength", "false"));
 
  if (PrimitiveType.CHAR == primitiveType)
@@ -89,13 +90,34 @@ public EncodedDataType(final Node node, final String givenName)
  final String nodeValue = node.getFirstChild().getNodeValue();
  if (PrimitiveType.CHAR == primitiveType)
  {
- if (nodeValue.length() == 1)
+ final int valueLength = nodeValue.length();
+
+ if (null != lengthAttr && length < valueLength)
+ {
+ handleError(node, "length of " + length + " is less than provided value: " + nodeValue);
+ }
+
+ if (valueLength == 1)
  {
- constValue = PrimitiveValue.parse(nodeValue, primitiveType, characterEncoding);
+ if (null == lengthAttr)
+ {
+ constValue = PrimitiveValue.parse(nodeValue, primitiveType, characterEncoding);
+ }
+ else
+ {
+ constValue = PrimitiveValue.parse(nodeValue, length, characterEncoding);
+ }
  }
  else
  {
- constValue = PrimitiveValue.parse(nodeValue, nodeValue.length(), characterEncoding);
+ if (null == lengthAttr)
+ {
+ constValue = PrimitiveValue.parse(nodeValue, valueLength, characterEncoding);
+ }
+ else
+ {
+ constValue = PrimitiveValue.parse(nodeValue, length, characterEncoding);
+ }
  }
  }
  else