fixed missing unification for console rules

Author: Orbiter

src/ai/susi/mind/SusiInference.java

@@ -328,8 +328,11 @@ private static final SusiThought see(SusiArgument flow, String transferExpr, Str
  */
  public SusiThought applyProcedures(SusiArgument flow) {
  Type type = this.getType();
+ String expression = this.getExpression();
+ if (expression != null && expression.length() > 0) {
+ expression = flow.unify(expression, true, Integer.MAX_VALUE);
+ }
  if (type == SusiInference.Type.console) {
- String expression = this.getExpression();
  // we have two ways to define a console rule:
  // with a "defintion" object which should have an "url" and "path" defined
  // with a "expression" object which has a susi db access string included
@@ -432,16 +435,16 @@ public SusiThought applyProcedures(SusiArgument flow) {
  }
  }
  if (type == SusiInference.Type.flow) {
- try {return flowProcedures.deduce(flow, this.getExpression());} catch (Exception e) {}
+ try {return flowProcedures.deduce(flow, expression);} catch (Exception e) {}
  }
  if (type == SusiInference.Type.memory) {
- try {return memoryProcedures.deduce(flow, this.getExpression());} catch (Exception e) {}
+ try {return memoryProcedures.deduce(flow, expression);} catch (Exception e) {}
  }
  if (type == SusiInference.Type.javascript) {
- try {return javascriptProcedures.deduce(flow, this.getExpression());} catch (Exception e) {}
+ try {return javascriptProcedures.deduce(flow, expression);} catch (Exception e) {}
  }
  if (type == SusiInference.Type.prolog) {
- try {return prologProcedures.deduce(flow, this.getExpression());} catch (Exception e) {}
+ try {return prologProcedures.deduce(flow, expression);} catch (Exception e) {}
  }
  // maybe the argument is not applicable, then an empty thought is produced (which means a 'fail')
  return new SusiThought();

src/ai/susi/mind/SusiIntent.java

@@ -654,9 +654,9 @@ public Collection<SusiMatcher> matcher(String s) {
  * @param language this is the language the user is speaking
  * @return an intent score: the higher, the better; null if the expression cannot be matched
  */
- public Score getScore(String expression, SusiLanguage language) {
+ public Score getScore(SusiLanguage language) {
  if (this.score != null) return score;
- this.score = new Score(expression, language);
+ this.score = new Score(language);
  if (this.score.score == Integer.MIN_VALUE) this.score = null;
  return this.score;
  }
@@ -680,7 +680,7 @@ public class Score {
  public long score;
  public String log;
 
- public Score(String expression, SusiLanguage userLanguage) {
+ public Score(SusiLanguage userLanguage) {
  if (SusiIntent.this.score != null) return;
 
  /*
@@ -791,14 +791,24 @@ public Score(String expression, SusiLanguage userLanguage) {
  }
 
  /**
- * If a intent is applied to an input stream, it must follow a specific process which is implemented
- * in this consideration method. It is called a consideration in the context of an AI process which
- * tries different procedures to get the optimum result, thus considering different intents.
- * @param query the user input
- * @param token the key from the user query which matched the intent tokens (also considering category matching)
+ * Several intents can be candidates for answer computation. Each of such an intent is expressed as
+ * an SusiIdea object. They are combined with a recall (data objects from past answer computations)
+ * and tested by construction of an answer as the result of a causality chain that is described in the
+ * idea. If the chain can be constructed by finding instances of variables, then this is a kind of
+ * proof that the answer is correct. That answer is returned in the SusiArgument object.
+ * @param idea the intent candidate
+ * @param recall the data objects from past computations
+ * @param identity the identity of the user
+ * @param userLanguage the language of the user
+ * @param minds the hierarchy of mind layers that may be used for reflection within the argument
  * @return the result of the application of the intent, a thought argument containing the thoughts which terminated into a final mindstate or NULL if the consideration should be rejected
  */
- public SusiArgument consideration(final String query, SusiThought recall, SusiIdea idea, boolean debug, ClientIdentity identity, SusiLanguage userLanguage, SusiMind... minds) {
+ public SusiArgument consideration(
+ SusiIdea idea,
+ SusiThought recall,
+ ClientIdentity identity,
+ SusiLanguage userLanguage,
+ SusiMind... minds) {
 
  SusiLinguistics.Token token = idea.getToken();
  HashSet<SusiThought> keynotes = new HashSet<>();
@@ -823,8 +833,9 @@ public SusiArgument consideration(final String query, SusiThought recall, SusiId
 
  DAO.log("Susi has an idea: on " + keynote.toString() + " apply " + this.toJSON());
  // we start with the recall from previous interactions as new flow
- final SusiArgument flow = new SusiArgument(identity, userLanguage, minds).think(recall);
- flow.think(keynote);
+ final SusiArgument flow = new SusiArgument(identity, userLanguage, minds) // empty flow
+ .think(recall) // the past
+ .think(keynote); // the now
 
  // lets apply the intents that belong to this specific consideration
  for (SusiInference inference: this.getInferences()) {
@@ -835,7 +846,7 @@ public SusiArgument consideration(final String query, SusiThought recall, SusiId
  if (implication.isFailed() || flow.mindstate().equals(implication)) continue alternatives; // TODO: do this only if specific marker is in intent
 
  // think
- flow.think(implication);
+ flow.think(implication); // the future
  }
 
  // add skill source

src/ai/susi/mind/SusiMind.java

@@ -421,7 +421,7 @@ public List<SusiIdea> creativity(String query, SusiLanguage userLanguage, SusiTh
  AtomicLong count = new AtomicLong(0);
  ideas.forEach(idea -> {
  SusiIntent intent = idea.getIntent();
- Score score = intent.getScore(query, userLanguage);
+ Score score = intent.getScore(userLanguage);
  assert score != null : "query = " + query;
  if (score != null) {
  long s = score.score;
@@ -451,7 +451,7 @@ public List<SusiIdea> creativity(String query, SusiLanguage userLanguage, SusiTh
  }
 
  if (debug) for (SusiIdea idea: plausibleIdeas) {
- Score score = idea.getIntent().getScore(query, userLanguage);
+ Score score = idea.getIntent().getScore(userLanguage);
  assert score != null;
  if (score == null) continue;
  DAO.log("creativity: skill=" + idea.getIntent().getSkillID());
@@ -516,7 +516,7 @@ public SusiThought react(String query, SusiLanguage userLanguage, ClientIdentity
  ideatest: for (SusiIdea idea: ideas) {
  // compute an argument: because one intent represents a horn clause, the argument is a deduction track, a "proof" of the result.
  long t5 = System.currentTimeMillis();
- SusiArgument argument = idea.getIntent().consideration(query, recall, idea, debug, identity, userLanguage, minds);
+ SusiArgument argument = idea.getIntent().consideration(idea, recall, identity, userLanguage, minds);
  long t6 = System.currentTimeMillis();
  if (t6 - t5 > 100) DAO.log("=== Wasted " + (t6 - t5) + " milliseconds with intent " + idea.getIntent().toJSON());