Fypp call update for windows compatability #742
Conversation
Updated top level CMakeLists to explicitly call the python interpreter when running fypp.
Added back fypp help string
jvdp1 left a comment
jvdp1 left a comment There was a problem hiding this comment.
Thank you for adding this check. However, it breaks the CI. Any idea why?
| | ||
| # --- find preprocessor | ||
| find_program(FYPP fypp) | ||
| # Find python. Python 3.5 or higher required for ftypp |
There was a problem hiding this comment.
| # Find python. Python 3.5 or higher required for ftypp | |
| # Find python. Python 3.5 or higher required for fypp |
There was a problem hiding this comment.
CMake wasn't find fypp. I had assumed (incorrectly) that the find_file function would find the fypp package if it had been installed. Doing some trials, its seem it will be difficult to reliably find fypp across the various installation options, without the user manually specifying the path via -DCMAKE_INCLUDE_PATH or similar.
Based on that, I think its worth considering including fypp in the stdlib package. Its a single py file, so relatively compact. and the fypp license allows it. The pull request has been updated to reflect this.
Understand if don't want to add, in that case I can close the pull request.
| @awvwgk any ideas on how to solve this issue? Maybe a solution like for I am not in favour of adding the fypp file into the stdlib project. |
awvwgk left a comment
awvwgk left a comment There was a problem hiding this comment.
I would prefer to download fypp from the repo or pypi rather than committing it to our repository.
3 participants
This is a small change I made to the fypp call in CMake so that it can run fypp and build on Windows. If CMake can't find fypp the location can be specified via '-DCMAKE_INCLUDE_PATH" variable when configuring project.