Skip to content

migrated code into different files #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 31, 2023
Merged

migrated code into different files #10

merged 8 commits into from
May 31, 2023

Conversation

@rajkumardongre
Copy link
Contributor

No description provided.

This was referenced May 28, 2023
Closed
Closed
milancurcic
milancurcic approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @rajkumardongre. See my question about the type of content_length.

And just a few minor things about style. For string literals, be consistent. It looked like you use single quotes more, so let's just use single quotes throughout. And another is about private and public attributes: Use private in all modules at the top, and then a separate public statement that lists publicly accessible entities. This allows the reader to easily scan the public things, rather than looking at individual declarations.
@rajkumardongre @milancurcic
update content_lenght to c_long kind
6a95faa 
Co-authored-by: Milan Curcic <caomaco@gmail.com>
@rajkumardongre rajkumardongre merged commit 1d726c1 into fortran-lang:main May 31, 2023
@rajkumardongre
Copy link
Contributor Author

Thanks @milancurcic for the reviews, and I will make sure to incorporate your suggestions in my future work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@rajkumardongre @milancurcic