Skip to content

Commit f72d1da

Browse files
authored
Merge pull request firebase#403 from firebase/project-fixes
Project fixes
2 parents 951d089 + 7eb864e commit f72d1da

File tree

18 files changed

+195
-318
lines changed

18 files changed

+195
-318
lines changed

FirebaseAuthUI/FUIAuthStrings.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@
137137
}
138138
}
139139
NSBundle *frameworkBundle = [FUIAuthUtils bundleNamed:bundleName];
140+
if (frameworkBundle == nil) {
141+
frameworkBundle = [NSBundle mainBundle];
142+
}
140143
return [frameworkBundle localizedStringForKey:key value:nil table:table];
141144
}
142145

FirebaseAuthUI/FUIAuthUtils.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ + (NSBundle *)bundleNamed:(NSString *)bundleName {
2626
NSBundle *frameworkBundle = nil;
2727
if (bundleName) {
2828
NSString *path = [[NSBundle mainBundle] pathForResource:bundleName ofType:@"bundle"];
29+
if (path == nil) {
30+
// Check framework resources if bundle isn't present in main bundle.
31+
path = [[NSBundle mainBundle] pathForResource:bundleName ofType:@"framework"];
32+
}
2933
frameworkBundle = [NSBundle bundleWithPath:path];
3034
} else {
3135
frameworkBundle = [NSBundle bundleForClass:[self class]];

FirebaseDatabaseUI/FUIArray.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
// clang-format on
2020

21-
@import FirebaseDatabase;
21+
#import <FirebaseDatabase/FirebaseDatabase.h>
2222

2323
#import "FUICollection.h"
2424

FirebaseDatabaseUI/FUICollectionViewDataSource.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
#import "FUICollectionViewDataSource.h"
2222
#import "FUIArray.h"
2323

24-
@import FirebaseDatabase;
25-
2624
@interface FUICollectionViewDataSource () <FUICollectionDelegate>
2725

2826
@property (nonatomic, readonly, nonnull) id<FUICollection> collection;

FirebaseDatabaseUI/FUIIndexCollectionViewDataSource.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414
// limitations under the License.
1515
//
1616

17-
@import UIKit;
18-
19-
@import FirebaseDatabase;
17+
#import <FirebaseDatabase/FirebaseDatabase.h>
18+
#import <UIKit/UIKit.h>
2019

2120
NS_ASSUME_NONNULL_BEGIN
2221

FirebaseDatabaseUI/FUIIndexTableViewDataSource.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414
// limitations under the License.
1515
//
1616

17-
@import UIKit;
18-
19-
@import FirebaseDatabase;
17+
#import <UIKit/UIKit.h>
18+
#import <FirebaseDatabase/FirebaseDatabase.h>
2019

2120
NS_ASSUME_NONNULL_BEGIN
2221

FirebaseDatabaseUI/FUISortedArray.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
@import FirebaseDatabase;
18-
19-
#import "FirebaseDatabaseUI.h"
17+
#import "FUIArray.h"
2018

2119
NS_ASSUME_NONNULL_BEGIN
2220

FirebaseDatabaseUI/FUITableViewDataSource.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
#import "FUIArray.h"
2222
#import "FUITableViewDataSource.h"
2323

24-
@import FirebaseDatabase;
25-
2624
@interface FUITableViewDataSource () <FUICollectionDelegate>
2725

2826
@property (strong, nonatomic, readwrite) UITableViewCell *(^populateCell)

FirebaseFirestoreUI/FUIBatchedArray.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
@import FirebaseFirestore;
17+
#import <FirebaseFirestore/FirebaseFirestore.h>
1818

1919
#import "FUISnapshotArrayDiff.h"
2020

FirebaseFirestoreUI/FUIFirestoreTableViewDataSource.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020

2121
#import "FUIFirestoreTableViewDataSource.h"
2222

23-
@import FirebaseFirestore;
24-
2523
@interface FUIFirestoreTableViewDataSource () <FUIBatchedArrayDelegate>
2624

2725
@property (strong, nonatomic, readwrite) UITableViewCell *(^populateCell)

0 commit comments

Comments
 (0)