test(package_info_plus): Fix integration test for Android #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
miquelbeltran approved these changes Jul 9, 2024
Member
miquelbeltran left a comment
miquelbeltran left a comment There was a problem hiding this comment.
Smart to use device_info_plus to determine the OS version in the unit tests ;)
Member
| Title should be |
miquelbeltran changed the title 
Collaborator Author
The first thing that came to my mind. Also, I don't know other ways to do this check.
Thanks for catching. Doing multiple things at once never ends well :( |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixing tests for
installerStorevalue on Android as it seems like since Android 14 OS returnscom.android.shellfor apps installed via package manager, adb command (I suppose so) instead ofnull. Don't see any mentions of it in the documentation. Earlier we didn't see this test failing because we had no API 34 in our build matrix.Checked with emulators and real phone with Android 14 - on Android 13 I see
null, while on 14 for both virtual and real device seecom.android.shellwhen installing example via Android Studio. I believe this fix for the integration test should be correct.