Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented Nov 29, 2021

Updates to the latest version of the webview_flutter_platform_interface and fix one analysis warning caused by this update. This will also fix the tree.

No version change: code changes don't affect client usage and purely ensure code is compliant with new code analysis rules.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.
Updates to the latest version of the webview_flutter_platform_interface and fix one analysis warning caused by this update. This will also fix the tree.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Nov 29, 2021
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit f581e13 into flutter:master Nov 29, 2021
@mvanbeusekom mvanbeusekom deleted the webview_wkwebview_tree_fix branch November 29, 2021 12:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
…on 1.5.2 (flutter#4554) * Updates webview_flutter_platform_interface to version 1.5.2 Updates to the latest version of the webview_flutter_platform_interface and fix one analysis warning caused by this update. This will also fix the tree. * Trigger build
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
…on 1.5.2 (flutter#4554) * Updates webview_flutter_platform_interface to version 1.5.2 Updates to the latest version of the webview_flutter_platform_interface and fix one analysis warning caused by this update. This will also fix the tree. * Trigger build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes needs tests p: webview_flutter Edits files for a webview_flutter plugin platform-ios

2 participants