Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

The plugin requires Flutter 2.5, which supports auto-registration of
Dart implementation code in platform packages, and the packages already
do auto-registration. This registration is therefore not needed, so can be
removed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.
The plugin requires Flutter 2.5, which supports auto-registration of Dart implementation code in platform packages, and the packages already do auto-registration. This registration is unused, so can be removed.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Nov 23, 2021

test-exempt: code removal and code refactor to support code removal

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@stuartmorgan-g stuartmorgan-g merged commit 1f0d278 into flutter:master Dec 8, 2021
@stuartmorgan-g stuartmorgan-g deleted the path-provider-registration-cleanup branch December 8, 2021 20:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 8, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
The plugin requires Flutter 2.5, which supports auto-registration of Dart implementation code in platform packages, and the packages already do auto-registration. This registration is unused, so can be removed.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
The plugin requires Flutter 2.5, which supports auto-registration of Dart implementation code in platform packages, and the packages already do auto-registration. This registration is unused, so can be removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.